fix: Syntax Error in testproject-tools-integration #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluong6
force-pushed
the
fix/syntaxerror
branch
from
b1353c5 to
1924612
Compare
fluong6
changed the title
ashwinimurt
reviewed
Feb 25, 2022
| { | ||
| serverSceneLoaded = true; | ||
| serverSceneUnloaded = true; |
There was a problem hiding this comment.
oops, I think the variable should be named serverSceneLoaded looking at the condition.
Change line 248 to var serverSceneLoaded = false;
|
These tests are probably not part of CI. Should look into adding them to CI. |
0xFA11
approved these changes
Feb 25, 2022
We turned off automation for this project because CI was unstable in #develop, so this must have been a bad merge and someone missed a manual testing step. Glad you found and submitted this Frank. Noels PR has CI automation turned back on so once that lands (or the split up PRs) we shouldn't have this happen anymore |
|
@ashwinimurt also helped me fix it and create my first PR. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing test