Skip to content

feat: Improve access to simulator parameters #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 25, 2022

Conversation

simon-lemay-unity
Copy link
Contributor

MTT-2619

This PR offers a cleaner way to manage the simulation pipeline parameters. There's now a dedicated section in the inspector for these parameters, and a dedicated method to set them (SetDebugSimulatorParameters). All of this used to be available already, but it was not very discoverable (editor preferences when in the editor, public fields in development builds) and was inconsistent with how other parameters are managed. The PR maintains backwards compatibility with these mechanisms.

Changelog

com.unity.netcode.adapter.utp

  • Added: New parameters are available to simulate network conditions (delay, jitter, packet loss) in the editor and in development builds. The parameters are available under the 'Debug Simulator' section of the 'Unity Transport' component, or can be set with the SetDebugSimulatorParameters call.

Testing and Documentation

  • Includes unit/integration test.
  • No documentation changes or additions were done. Could be interesting to update the public documentation.

@simon-lemay-unity simon-lemay-unity enabled auto-merge (squash) February 25, 2022 19:10
@simon-lemay-unity simon-lemay-unity merged commit 61af2b3 into develop Feb 25, 2022
@simon-lemay-unity simon-lemay-unity deleted the feat/better-adapter-simulator-parameters branch February 25, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants