Skip to content

fix: network animator override #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 23, 2022
Merged

Conversation

mattwalsh-unity
Copy link
Contributor

This addresses MTT-2530, that using an Animator Override controller breaks the "always sync" checkboxes in the editor. This was a pretty straightforward bugfix

I also create a NetworkAnimator test

Changelog

com.unity.netcode.gameobjects

  • Added: The package whose Changelog should be added to should be in the header. Delete the changelog section entirely if it's not needed.
  • Fixed: If you update multiple packages, create a new section with a new header for the other package.
  • Removed/Deprecated/Changed: Each bullet should be prefixed with Added, Fixed, Removed, Deprecated, or Changed to indicate where the entry should go.

Testing and Documentation

  • Includes integration tests.
  • We should update the documentation to point out that (now) you can use the Animator Override controller

@mattwalsh-unity mattwalsh-unity changed the title Fix/network aminator override fix: network animator override Feb 22, 2022
@@ -66,7 +66,17 @@ private void DrawControls()
return;
}

var controller = m_AnimSync.Animator.runtimeAnimatorController as AnimatorController;
AnimatorController controller;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes [MTT-2530]

@mattwalsh-unity mattwalsh-unity marked this pull request as ready for review February 22, 2022 20:32
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the SendMessagesAllowed perf hit, the rest looks good to me!

@mattwalsh-unity mattwalsh-unity enabled auto-merge (squash) February 22, 2022 23:28
@mattwalsh-unity mattwalsh-unity merged commit 88ee99c into develop Feb 23, 2022
@mattwalsh-unity mattwalsh-unity deleted the fix/network-aminator-override branch February 23, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants