Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: networkscenemanager interface override (backport) #1691

Merged

Conversation

NoelStephensUnity
Copy link
Collaborator

Summary

This removes all unit test checks within NetworkSceneManager in order to allow for better integration testing. This version intercepts the SceneManager's Load and Unload via the ISceneManagerHandler implementation that is overridden during unit testing in order to prevent clients from actually loading scenes when they don't need to and it provides the ability to allow clients to load scenes during unit/integration tests.

Additional Changes

  • Made minor tweaks to SceneEventTests
  • Adjusted some Transport tests to destroy the GameObject and not just the component
  • Adjusted the BaseMultiInstanceTest Coroutine destruction to destroy the GameObject and not just the component.

MTT-1672

This is a backport of #1405 into the develop branch (from experimental-develop)

Testing and Documentation

  • No tests have been added (all existing tests validate the changes made)
  • No documentation changes or additions were necessary.

This includes the core changes to NetworkSceneManager, integration test helper classes, and the scene handler integration test.
Updated all of the rest of the tests that were modified in PR-1405
Missed an update in NetworkScenemanagerTests
NoelStephensUnity added a commit that referenced this pull request Feb 14, 2022
Merging #1691 into this branch ahead of it being merged to continue working on mtt-2435 while it waits to get approved.
@NoelStephensUnity NoelStephensUnity marked this pull request as draft February 14, 2022 19:43
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review February 14, 2022 21:26
@0xFA11 0xFA11 changed the title feat: networkscenemanager interface override backport to develop feat: networkscenemanager interface override (backport) Feb 15, 2022
@0xFA11 0xFA11 merged commit bedc637 into develop Feb 15, 2022
@0xFA11 0xFA11 deleted the fix/networkscenemanager-interface-override-backport-develop branch February 15, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants