Skip to content

fix: unet removed from unity trunk #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 11, 2022
Merged

fix: unet removed from unity trunk #1678

merged 9 commits into from
Feb 11, 2022

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Feb 11, 2022 •
edited
Loading

Fixing the most recent update to unity trunk where UNet no longer exists.
MTT-2483

Testing and Documentation

  • No tests were included
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
cddeddc 
Updating the NGO assembly.
@NoelStephensUnity
fix
e613244 
excluding unet if it is not present.
@NoelStephensUnity NoelStephensUnity marked this pull request as draft February 11, 2022 02:42
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review February 11, 2022 03:16
@NoelStephensUnity
fix
ee216a5 
Missed a few spots
0xFA11
0xFA11 reviewed Feb 11, 2022
View reviewed changes
@NoelStephensUnity
fix
7312630 
CommandLineHandler had references to UNetTransport
@NoelStephensUnity
fix
6da273b 
Excluding Unity.Netcode.Transports.UNET from NetworkManagerHelper.
@simon-lemay-unity
Copy link
Contributor

Shouldn't this be marked for backporting to 1.0.0? There already are bug reports about this. Depending on how fast you guys plan on making UTP the default, you might want to make a release with this fix...

In any case, if it is possible that users will use this fix before UTP is the default, it might be a good idea to indicate in one way or another that they should install the UTP adapter. Otherwise they'll just be faced with a netcode solution that doesn't include a transport.

NoelStephensUnity and others added 2 commits February 11, 2022 09:53
@NoelStephensUnity
style
3fede01 
removing commented out UNet references and adding additional comments.
@NoelStephensUnity
update
cb851ab 
removing the relay stuff as it was not needed.
@NoelStephensUnity
update
96a5e34 
Adding UnityTransport support to the CommandLineHandler.
@NoelStephensUnity NoelStephensUnity mentioned this pull request Feb 11, 2022
Merged
@NoelStephensUnity NoelStephensUnity merged commit 1b6598d into develop Feb 11, 2022
@NoelStephensUnity NoelStephensUnity deleted the fix/unet-removed-from-unity-trunk branch February 11, 2022 21:21
@0xFA11 0xFA11 mentioned this pull request Feb 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFA11 0xFA11 0xFA11 approved these changes

@simon-lemay-unity simon-lemay-unity simon-lemay-unity approved these changes

@becksebenius-unity becksebenius-unity Awaiting requested review from becksebenius-unity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoelStephensUnity @simon-lemay-unity @0xFA11