fix: Fix handling of disconnection events in the adapter #1673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTT-2467
How the adapter handled
Disconnect
events from the transport needed to be fixed in two ways:m_State
would be set toDisconnected
, but that should only be done on clients. Hosts have theirm_State
set toListening
and it should stay that way after a client has disconnected. This is likely what was causing MTT-2467.This PR also brings in changes from PR #1649 since it provides a clean way of clearing the send queues. I also modified the connection tests to improve their stability (waiting for the client to be connected since this guarantees the server also is, otherwise there could be timing issues where the server is connected but not the client).
Changelog
com.unity.netcode.adapter.utp
Testing and Documentation