Skip to content

fix: TestProject.RuntimeTests do not run in stand alone test runner builds and fail on consoles #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 24 commits into from
Closed

fix: TestProject.RuntimeTests do not run in stand alone test runner builds and fail on consoles #1644

wants to merge 24 commits into from

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Feb 2, 2022 •
edited
Loading

This includes the adjustments required to get the TestProject.RuntimeTests building as a stand alone test runner build:
MTT-2313
This includes the adjustments required to get the TestProject.RuntimeTests tests passing when ran in a stand alone test runner build (which should pass on consoles but is still TBD)
MTT-2376

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

NoelStephensUnity and others added 23 commits February 1, 2022 12:14
@NoelStephensUnity
refactor
d5efbe6 
This commit migrates the NetworkPrefabGlobalObjectIdHashTests and NetworkObjectGlobalObjectIdHashTests into the TestProject.EditorTests assembly since they depend upon editor specific library calls and could be run as EditMode tests.
@NoelStephensUnity
refactor
d8e5b1f 
This commit changes the NetworkObjectParentingTests and ReparentingCubeNetBhv namespace to TestProject.RuntimeTests and uses the standard SceneManager to load the scene as opposed to the editor version.
@NoelStephensUnity
update
a967264 
Modifying the TestProject.RuntimeTests assembly to be a runtime only assembly.
Had to migrate the TestProject.RuntimeTests out of the #if UNITY_EDITOR region in order to be able to compile a stand alone test runner build.
@NoelStephensUnity
fix
2f18881 
The following updates to the MessageOrdering tests should get them working on consoles.
@NoelStephensUnity
fix
0b955fe 
This fixes the issues with running NestedNetworkManagerTests in a stand alone test runner build and should run on consoles.
@NoelStephensUnity
fix
1ee1297 
The following updates to NetworkSceneManagerDDOLTests in NetworkSceneManagerTests.cs get it passing in a stand alone test runner build which should make it console friendly.
@NoelStephensUnity
fix
c47ea65 
Fixing issues with the NetworkPrefabPoolAdditive class that is used in several tests including the NetworkSceneManagerTests.  The issues fixed were related to object references not being around (i.e. NetworkManager) as well as came up with a better way to detect if the coroutine was running in order to determine if it needed to be stopped.
@NoelStephensUnity
fix
2fa12fa 
This fixes the issues with running the NetworkVariableInitializationOnNetworkSpawnTest when it was run in a stand alone test runner build which should be console friendly at this point.
@NoelStephensUnity
Merge branch 'develop' into fix/test-roject-runtimetests-standalone-t…
bee18d3 
…estrunner-build
@NoelStephensUnity
Merge branch 'develop' into fix/test-roject-runtimetests-standalone-t…
2480daf 
…estrunner-build
@NoelStephensUnity
refactor
67566d6 
Removing assembly references not being used.
@NoelStephensUnity
test
76af4d4 
turning off the Unity.Netcode.RuntimeTests on console platforms temporarily in order to run just the TestProject.RuntimeTests on consoles.
@NoelStephensUnity
test
312a5f5 
Seeing if this fixes the weird issue with the standards failing.
@NoelStephensUnity
revert
5319473 
reverting as this was a dumb approach.
@NoelStephensUnity
test
a2f6fca 
disabling all tests in Unity.Netcode.RuntimeTest
@NoelStephensUnity
test refactor
091d82f 
Needed some MULTIPLAYER_TOOLS helpers that I accidentally excluded.
@NoelStephensUnity
test fix
5915c3e 
Trying to figure out weird ILCPP serialization issue.
@NoelStephensUnity
test update
82606ea 
Still trying to get rid of IL2CPP error
@NoelStephensUnity
style
85fded2 
white spaces.
@NoelStephensUnity
fix
8ad9b42 
This is a work around for the MTT-1703 issue with RPCs.
@NoelStephensUnity
test update
ce84aba 
This test was failing on some of the console platforms.  Made adjustments to avoid timing issues.
@NoelStephensUnity
style
1c2d493 
white space update
@NoelStephensUnity
Revert "test"
455a756 
This reverts commit a2f6fca.
@NoelStephensUnity NoelStephensUnity mentioned this pull request Feb 3, 2022
Closed
@NoelStephensUnity NoelStephensUnity changed the title fix: test project runtime tests fail in standalone testrunner build fix: TestProject.RuntimeTests do not run in stand alone test runner builds and fail on consoles Feb 3, 2022
@NoelStephensUnity NoelStephensUnity mentioned this pull request Feb 5, 2022
Closed
@NoelStephensUnity NoelStephensUnity mentioned this pull request Feb 8, 2022
Merged
@NoelStephensUnity NoelStephensUnity deleted the fix/test-roject-runtimetests-standalone-testrunner-build branch March 22, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NoelStephensUnity