refactor: Splitting MessagingSystem.SendMessage into a second part … #1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alizedMessage. This allows SnapshotSystem to send larger messages, while saving an allocation and a copy.
jeffreyrainy
commented
Feb 1, 2022
| @@ -919,8 +919,7 @@ internal void NetworkGetBehaviourVariable(UpdateCommand updateCommand, out Netwo | |||
|
|
|||
| internal int NetworkSendMessage(SnapshotDataMessage message, ulong clientId) | |||
| { | |||
| m_NetworkManager.SendMessage(ref message, NetworkDelivery.ReliableFragmentedSequenced, clientId); | |||
|
|
|||
| m_NetworkManager.SendPreSerializedMessage(message.WriteBuffer, TotalBufferMemory, ref message, NetworkDelivery.Unreliable, clientId); | |||
There was a problem hiding this comment.
This simply calls a bit further in, after tmpSerializer, because we happen to have such a FastBufferWriter ready.
jeffreyrainy
commented
Feb 1, 2022
| @@ -352,7 +352,7 @@ private bool CanSend(ulong clientId, Type messageType, NetworkDelivery delivery) | |||
| return true; | |||
| } | |||
|
|
|||
| internal unsafe int SendMessage<TMessageType, TClientIdListType>(ref TMessageType message, NetworkDelivery delivery, in TClientIdListType clientIds) | |||
| internal int SendMessage<TMessageType, TClientIdListType>(ref TMessageType message, NetworkDelivery delivery, in TClientIdListType clientIds) | |||
There was a problem hiding this comment.
Simply split the function in two parts. The first part doesn't need the unsafe keyword anymore
jeffreyrainy
commented
Feb 1, 2022
| @@ -426,6 +432,13 @@ private bool CanSend(ulong clientId, Type messageType, NetworkDelivery delivery) | |||
| return tmpSerializer.Length + headerSerializer.Length; | |||
| } | |||
|
|
|||
| internal unsafe int SendPreSerializedMessage<TMessageType>(in FastBufferWriter tmpSerializer, int maxSize, ref TMessageType message, NetworkDelivery delivery, ulong clientId) | |||
There was a problem hiding this comment.
Adds an entrypoint taking a single clientId instead of a PointerListWrapper, because that class is private.
…dPreSerializedMessage. This allows SnapshotSystem to send larger messages, while saving an allocation and a copy.
…ty-Technologies/com.unity.multiplayer.mlapi into refactor/send-message-pre-serialized
…age-pre-serialized
jeffreyrainy
added a commit
that referenced
this pull request
Feb 16, 2022
…1642) * Splitting MessagingSystem.SendMessage into a second part, SendPreSerializedMessage. This allows SnapshotSystem to send larger messages, while saving an allocation and a copy. * refactor: Splitting MessagingSystem.SendMessage into second part, SendPreSerializedMessage. This allows SnapshotSystem to send larger messages, while saving an allocation and a copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SendPreSerializedMessage. This allows SnapshotSystem to send larger messages, while saving an allocation and a copy.