fix: Endpoint creation fails with empty listen address #1636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFA11
approved these changes
Jan 29, 2022
0xFA11
added
stat:backported-release-1.0.0
and removed
type:backport-release-1.0.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTT-2296
Fix the issue where the server endpoint creation would fail in the adapter when the listen address was empty. It's okay for it to be empty, but when I had written this I had (naively) used null as the empty value. But Unity deserializes null string fields as
string.Empty, not as null. The error is on me, I should have double-checked how Unity handles deserialization of string fields.Changelog
com.unity.netcode.adapter.utp
NetworkEndPointwould fail to be created when 'Server Listen Address' is empty.Testing and Documentation