fix: NetworkManager always sent to the DDOL and cannot be nested - release 1.0.0 backport #1623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwalsh-unity
approved these changes
Jan 26, 2022
There was a problem hiding this comment.
I am assuming as I approve per my chat w/ @NoelStephensUnity that the only things new here vs #1484 were changes in NetworkTransformTests.cs and SceneReferenceValidationState.cs, neither of which affect any of the implementation
…or-check-release-1.0.0
|
cc @ashwinimurt to get pinged when this is merged. |
ashwinimurt
approved these changes
Jan 27, 2022
|
Merging after speaking with Noel. |
ashwinimurt
deleted the
fix/nested-networkmanager-ddol-editor-check-release-1.0.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Networkmanage 's gameObject can't be a child of another gameObject. otherwise will show this issue:
Exception: Failed to find any loaded scene named "XXXX"
and everything related to the network will not working.
This addresses Github-Issue #1417 (described above) where users will now be provided notifications that the NetworkManager cannot be parented under another GameObject (nested). This PR also removes the DontDestroy property from the NetworkManager so that no NetworkManager instance can be destroyed by unloading a scene.
Development Standalone Build: The in-engine debug console displays the message that they cannot nest a NetworkManager
Editor Edit-Mode: A dialog box notifies the user that they cannot nest a NetworkManager and provides the option for the user to auto-fix or manually fix it
Editor Play-Mode: A dialog box just notifies the user that they cannot nest a NetworkManager
MTT-1732
This is a backport of PR-1484
PR Checklist
CHANGELOG.mdfile.Changelog
com.unity.netcode.gameobjects
Testing and Documentation
Includes editor and runtime tests to validate the fix
No documentation changes or additions were necessary.