fix: refresh cancommit value of ClientNetworkTransform - release 1.0.0 backport #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit fba06f5)
LukeStampfli
changed the title
ashwinimurt
approved these changes
Jan 26, 2022
…ner-release-1.0.0
| @@ -26,6 +26,7 @@ public override void OnNetworkSpawn() | |||
|
|
|||
| protected override void Update() | |||
| { | |||
| CanCommitToTransform = IsOwner; | |||
There was a problem hiding this comment.
I guess this is needed in addition to the OnNetworkSpawn call because this can change between ONS and Update? Because this seems a bit odd I think this is worth a comment
There was a problem hiding this comment.
Also, I guess one could think "why does ClientNT have this setting in Update and ONS but regular NT only has it in ONS
There was a problem hiding this comment.
Yeah you're right this would have been worth a comment but I already merged the original PR this is just the backport 😭
mattwalsh-unity
approved these changes
Jan 26, 2022
mattwalsh-unity
deleted the
fix/clientnetworktransform-updateowner-release-1.0.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #1606