feat: Simpler relay data setters in the adapter #1609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTT-1870
This addresses issue #1259. Basically the use
SetRelayServerData
is error-prone because it requires being called differently on hosts and clients. This PR introducesSetHostRelayData
andSetClientRelayData
to make this simpler. They're basically just wrappers aroundSetRelayServerData
, but impose the correct usage depending on if you're a host or a client.Even though they are meant to replace
SetRelayServerData
, I am not deprecating it since there is documentation referring to it. Once that PR is part of a released version, I will reach out to the team responsible for the relay documentation and work with them to update it to use the new methods. Once that is online, we'll be able to start the deprecation process forSetRelayServerData
. I've entered MTT-2240 in JIRA to track this effort.Changelog
com.unity.adapter.utp
SetHostRelayData
andSetClientRelayData
. These are meant to be less error-prone thanSetRelayServerData
(which remains available).Testing and Documentation