chore: update sdk package dependencies #1565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFA11
requested review from
ShadauxCat
and removed request for
mattwalsh-unity
ShadauxCat
approved these changes
Jan 5, 2022
| @@ -7,8 +7,10 @@ | |||
| "dependencies": { | |||
| "com.unity.modules.ai": "1.0.0", | |||
There was a problem hiding this comment.
I still wonder why we depend on AI
There was a problem hiding this comment.
very good question. we used to have NetworkNavMeshAgent but we no longer have it. I'll double check and potentially remove AI package dependency.
There was a problem hiding this comment.
Bravo - the world is now a slightly better place
mattwalsh-unity
approved these changes
Jan 6, 2022
0xFA11
changed the title
0xFA11
added
stat:backported-release-1.0.0
and removed
type:backport-release-1.0.0
labels
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user discovered (#1558) that we don't depend on physics and physics2d packages from the SDK package atm.
We have
NetworkRigidbodyandNetworkRigidbody2Dcomponents in the SDK which have deps to those packages.Even though we might move high-level components into a separate package later, currently we should add those deps to make them explicit and clear to avoid confusion.
JIRA: MTT-2033
PR Checklist
type:backport-release-*label. After you backport the PR, the label changes tostat:backported-release-*.CHANGELOG.mdfile.Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR or a link to the documenation repo PR if this is a manual update.Changelog
com.unity.netcode.gameobjects