feat: Adding "previousValue" in NetworkListEvent #1528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, instead of users having to maintain a local value themselves, we just add it when individual values changes. It'll stay to default with other event types (just like "index" stays to default when the event type doesn't have an index)
mattwalsh-unity
approved these changes
Dec 15, 2021
4 tasks
SamuelBellomo
added a commit
that referenced
this pull request
Jan 11, 2022
* Quality of life, adding "previousValue" field in list events. This way, instead of users having to maintain a local value themselves, we just add it when individual values changes. It'll stay to default with other event types (just like "index" stays to default when the event type doesn't have an index) * update to changelog (cherry picked from commit 2742346)
3 tasks
0xFA11
reviewed
Jan 11, 2022
| @@ -9,6 +9,7 @@ Additional documentation and release notes are available at [Multiplayer Documen | |||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
| - Adding `PreviousValue` in NetworkListEvent, when `Value` has changed | |||
There was a problem hiding this comment.
:(
- - Adding `PreviousValue` in NetworkListEvent, when `Value` has changed
+ - Adding `PreviousValue` in NetworkListEvent, when `Value` has changed (#1528)
0xFA11
pushed a commit
that referenced
this pull request
Jan 12, 2022
0xFA11
added
stat:backported-release-1.0.0
and removed
type:backport-release-1.0.0
labels
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…1528) * Quality of life, adding "previousValue" field in list events. This way, instead of users having to maintain a local value themselves, we just add it when individual values changes. It'll stay to default with other event types (just like "index" stays to default when the event type doesn't have an index) * update to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, instead of users having to maintain a local value themselves, we just add it when individual values changes. It'll stay to default with other event types (just like "index" stays to default when the event type doesn't have an index)
No Jira
PR Checklist
type:backport-release-*label. After you backport the PR, the label changes tostat:backported-release-*.CHANGELOG.mdfile.Changelog
com.unity.netcode.gameobjects
PreviousValuein NetworkListEvent, whenValuehas changedTesting and Documentation