Skip to content

fix: host NetworkManager.LocalClient not being set #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 9, 2021

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Dec 8, 2021

When starting as a host, the NetworkManager.LocalClient was never being set.
MTT-1914

PR Checklist

  • Have you added a backport label (if needed)? For example, the type:backport-release-* label. After you backport the PR, the label changes to stat:backported-release-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.

Changelog

com.unity.netcode.gameobjects

Fixed NetworkManager.LocalClient not being set when starting as a host.

Testing and Documentation

  • Includes integration tests.

Fixes the issue with the host not having a NetworkManager.LocalClient assigned after starting.
The test to validate the fix
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) December 9, 2021 15:10
@NoelStephensUnity NoelStephensUnity merged commit a5ad2af into develop Dec 9, 2021
@NoelStephensUnity NoelStephensUnity deleted the fix/networkmanager-host-localclient-null branch December 9, 2021 18:30
mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
…s#1511)

* fix

Fixes the issue with the host not having a NetworkManager.LocalClient assigned after starting.

* test

The test to validate the fix

* updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants