Skip to content

test: added test to confirm client ID on disconnect is correct #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2021
Merged

test: added test to confirm client ID on disconnect is correct #1482

merged 2 commits into from
Dec 7, 2021

Conversation

ShadauxCat
Copy link
Collaborator

Tests to exercise the fix to #1440 from PR #1477.

I started doing redundant work only to realize Andrew had already submitted a fix, but the tests are still valid.

MTT-1846

0xFA11
0xFA11 approved these changes Dec 5, 2021
View reviewed changes
Copy link
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for the test!
do you think that we should close issue #1440 too now?

@ShadauxCat
Copy link
Collaborator Author

do you think that we should close issue #1440 too now?

Absolutely, I'll do that.

@ShadauxCat ShadauxCat merged commit f8977a3 into develop Dec 7, 2021
@ShadauxCat ShadauxCat deleted the test/client_id_on_disconnect branch December 7, 2021 20:55
@0xFA11 0xFA11 mentioned this pull request Feb 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFA11 0xFA11 0xFA11 approved these changes

@mattwalsh-unity mattwalsh-unity mattwalsh-unity approved these changes

@andrews-unity andrews-unity Awaiting requested review from andrews-unity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShadauxCat @0xFA11 @mattwalsh-unity