fix: In-scene NetworkObjects disabled but never re-enabled after scen… #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e transition (#1354) * fix This is the fix for the in-scene NetworkObjects moved into DDOL and the after a scene transition they become disabled but never re-enabled. * test Had to make some private methods internal for testing purposes. Adding test to validate the fix. * style white space fixes. * style Adding comment above the primary line of code that is the fix for this PR * style removing unused namespace. * style removing several LFs * fix and test This now tracks the state of NetworkObjects when a full scene transition takes place. This includes a refactored test for NetworkObjects (dynamically spawned and in-scene placed) that persist a full scene transition. * test update This makes sure that DestroyWithScene is set to false for all InSceneNetworkObjectState tests. * style Removing whitespace. * updated changelog Added entries for the fixes applied in this PR. * refactor After peer review during PR Triage we all decided to not change or track a NetworkObject's parent GameObject's state and to not disable during full scene transition. Removed all active state tracking dictionaries and references as well as removed disabling DDOL migrated GameObjects from the runtime NGO code base. Adjusted the DDOL test to check the state is maintained throughout the scene transition. The DDOL test only required a minor * updated changelog Updating the changelog to reflect most recent updates.
0xFA11
approved these changes
Nov 24, 2021
andrews-unity
deleted the
backport/1.0.0-fix-InScene-NetworkObjects-DDOL-Disabled-MTT-1479
branch
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…e transition (Unity-Technologies#1354) (Unity-Technologies#1465) * fix This is the fix for the in-scene NetworkObjects moved into DDOL and the after a scene transition they become disabled but never re-enabled. * test Had to make some private methods internal for testing purposes. Adding test to validate the fix. * style white space fixes. * style Adding comment above the primary line of code that is the fix for this PR * style removing unused namespace. * style removing several LFs * fix and test This now tracks the state of NetworkObjects when a full scene transition takes place. This includes a refactored test for NetworkObjects (dynamically spawned and in-scene placed) that persist a full scene transition. * test update This makes sure that DestroyWithScene is set to false for all InSceneNetworkObjectState tests. * style Removing whitespace. * updated changelog Added entries for the fixes applied in this PR. * refactor After peer review during PR Triage we all decided to not change or track a NetworkObject's parent GameObject's state and to not disable during full scene transition. Removed all active state tracking dictionaries and references as well as removed disabling DDOL migrated GameObjects from the runtime NGO code base. Adjusted the DDOL test to check the state is maintained throughout the scene transition. The DDOL test only required a minor * updated changelog Updating the changelog to reflect most recent updates. Co-authored-by: Noel Stephens <noel.stephens@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #1354