fix: Prevent an exception in UTP when host disconnects #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was invoking the disconnect transport event callback on the manager before doing some checks on UTP's NetworkConnection. But on a client, that callback ends up calling Shutdown on the transport. This disposes of the driver so the checks that follow end up throwing an exception. The fix was to reorder the checks before the callback. Also fix the logic that checked if there was a connection failure. It was checking if the state of the connection was Connecting, but that's never the case after a Disconnect event (the state will always be Disconnected).
simon-lemay-unity
added
type:backport-release-1.0.0
and removed
type:backport-release-1.0.0
labels
andrews-unity
approved these changes
Nov 22, 2021
This was referenced Nov 22, 2021
andrews-unity
added
stat:backported-release-1.0.0
and removed
type:backport-release-1.0.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was invoking the disconnect transport event callback on the manager before doing some checks on UTP's
NetworkConnection. But on a client, that callback ends up callingShutdownon the transport. This disposes of the driver so the checks that follow end up throwing an exception. The fix was to reorder the checks before the callback.Also fix the logic that checked if there was a connection failure. It was checking if the state of the connection was
Connecting, but that's never the case after aDisconnectevent (the state will always beDisconnected). Instead, check the disconnect reason.Fixes #1439.
Changelog
com.unity.netcode.adapter.utp
Testing and Documentation