Skip to content

refactor: remove misc defunct files #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 10, 2021

Conversation

mattwalsh-unity
Copy link
Contributor

@mattwalsh-unity mattwalsh-unity commented Nov 5, 2021

This PR removes a number of files that are no longer in use in metrics, collections and reflection.

PR Checklist

  • Have you added a backport label (if needed)? For example, the type:backport-release-* label. After you backport the PR, the label changes to stat:backported-release-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR or a link to the documenation repo PR if this is a manual update.

Changelog

com.unity.netcode.gameobjects

Removed FixedQueue
Removed StreamExtensions
Removed TypeExtensions

  • No tests have been added.

Copy link
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you don't mind updating CHANGELOG.md file with removed public types (and also tag #1398 PR number too), I think we could get this in.

@unity-cla-assistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@andrews-unity andrews-unity merged commit 7730716 into develop Nov 10, 2021
@andrews-unity andrews-unity deleted the refactor/remove-misc-defunct branch November 10, 2021 07:12
andrews-unity pushed a commit that referenced this pull request Nov 24, 2021
* refactor: remove misc defunct files
andrews-unity added a commit that referenced this pull request Nov 24, 2021
* refactor: remove misc defunct files

Co-authored-by: Matt Walsh <69258106+mattwalsh-unity@users.noreply.github.com>
Co-authored-by: Unity Netcode CI <74025435+netcode-ci-service@users.noreply.github.com>
mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
* refactor: remove misc defunct files

* Adding things into changelist
mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
…Technologies#1458)

* refactor: remove misc defunct files

Co-authored-by: Matt Walsh <69258106+mattwalsh-unity@users.noreply.github.com>
Co-authored-by: Unity Netcode CI <74025435+netcode-ci-service@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants