Skip to content

fix: remove the buffer size limit when computing a hash in NetworkConfig #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 10, 2021

Conversation

ShadauxCat
Copy link
Collaborator

MTT-1550

Fixes #1361

Changelog

com.unity.netcode.gameobjects

  • Fixed: NetworkConfig will no longer throw an OverflowException in GetConfig() when ForceSamePrefabs is enabled and the number of prefabs causes the config blob size to exceed 1300 bytes.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@andrews-unity andrews-unity merged commit 9a239f9 into develop Nov 10, 2021
@andrews-unity andrews-unity deleted the fix/remove_network_config_buffer_size_limit branch November 10, 2021 20:09
andrews-unity pushed a commit that referenced this pull request Nov 24, 2021
…fig (#1385)

* fix: remove the buffer size limit when computing a hash in NetworkConfig

* Changelog entry

* Moved changelog entry to Unreleased
andrews-unity added a commit that referenced this pull request Nov 24, 2021
…fig (#1385) (#1461)

* fix: remove the buffer size limit when computing a hash in NetworkConfig

* Changelog entry

* Moved changelog entry to Unreleased

Co-authored-by: Jaedyn Draper <284434+ShadauxCat@users.noreply.github.com>
Co-authored-by: Unity Netcode CI <74025435+netcode-ci-service@users.noreply.github.com>
mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
…fig (Unity-Technologies#1385)

* fix: remove the buffer size limit when computing a hash in NetworkConfig

* Changelog entry

* Moved changelog entry to Unreleased
mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
…fig (Unity-Technologies#1385) (Unity-Technologies#1461)

* fix: remove the buffer size limit when computing a hash in NetworkConfig

* Changelog entry

* Moved changelog entry to Unreleased

Co-authored-by: Jaedyn Draper <284434+ShadauxCat@users.noreply.github.com>
Co-authored-by: Unity Netcode CI <74025435+netcode-ci-service@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS: Writing past the end of the buffer in Unity.Netcode.NetworkConfig.GetConfig
4 participants