Skip to content

fix: Resolving issue where IL2CPP would not compile #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2021
Merged

fix: Resolving issue where IL2CPP would not compile #1359

merged 3 commits into from
Oct 27, 2021

Conversation

andrews-unity
Copy link
Contributor

@andrews-unity andrews-unity commented Oct 27, 2021 •
edited by JesseOlmer
Loading

IL2CPP is very specific about the IL it reads and in this case it could not properly resolve a stack variable with the previous IL so we have to declare a variable explicitly.

PR Checklist

  • Have you added a backport label (if needed)? For example, the type:backport-release-* label. After you backport the PR, the label changes to stat:backported-release-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR or a link to the documenation repo PR if this is a manual update.

Changelog

com.unity.netcode.gameobjects

  • Fixed: IL2CPP would not properly compile

Testing and Documentation

  • No tests have been added.

@andrews-unity
fix: Fixing an issue where IL2CPP is not smart enough to ensure what …
17d402d 
…is being popped off the stack so we need to be explicit with a variable
@andrews-unity andrews-unity requested a review from 0xFA11 October 27, 2021 02:30
@0xFA11 0xFA11 merged commit 35e14e8 into develop Oct 27, 2021
@0xFA11 0xFA11 deleted the fix/ilpp-try-catch-il2cpp branch October 27, 2021 09:51
@andrews-unity andrews-unity mentioned this pull request Oct 28, 2021
Merged
3 tasks
mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
@andrews-unity
fix: Resolving issue where IL2CPP would not compile (Unity-Technologi…
3f28c10 
…es#1359)

* fix: Fixing an issue where IL2CPP is not smart enough to ensure what is being popped off the stack so we need to be explicit with a variable

* fix: standards.py

* [skip ci] updating changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFA11 0xFA11 0xFA11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrews-unity @0xFA11