fix: expose timeout configs for UTP and enable heartbeats #1314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseOlmer
reviewed
Oct 20, 2021
mattwalsh-unity
approved these changes
Oct 22, 2021
andrews-unity
added a commit
that referenced
this pull request
Oct 22, 2021
3 tasks
andrews-unity
added
stat:backported-release-1.0.0
and removed
type:backport-release-1.0.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing timeout params for UTP as well as resolving an issue where in Editor/Dev builds heartbeats where not functioning.
DST-628
Changelog
com.unity.netcode.adapter.utp
m_HeartbeatTimeoutMS,m_ConnectTimeoutMS,m_MaxConnectAttempts, andm_DisconnectTimeoutMSparametersTesting and Documentation