fix: netvar client initialization #1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… correctly to clients as initialization and not delta
mattwalsh-unity
approved these changes
Oct 6, 2021
| @@ -419,7 +419,7 @@ internal void SendSpawnCallForObject(ulong clientId, NetworkObject networkObject | |||
|
|
|||
| var message = new CreateObjectMessage | |||
| { | |||
| ObjectInfo = networkObject.GetMessageSceneObject(clientId, false) | |||
| ObjectInfo = networkObject.GetMessageSceneObject(clientId) | |||
There was a problem hiding this comment.
Looks correct, just wondering why it was 'false' previously.
There was a problem hiding this comment.
I was also wondering that, but it definitely seems like it should be true.
|
|
||
| namespace TestProject.RuntimeTests | ||
| { | ||
| public class NetworkVariableInitializationOnNetworkSpawnTest |
There was a problem hiding this comment.
All looks good, I think I would suggest this could live in NetworkVariableTests. Also in that file you might see you can do the same tests a bit more concisely with the RunAndWaitForCondition helper
0xFA11
approved these changes
Oct 6, 2021
mattwalsh-unity
deleted the
fix/netvar_initialization_in_onnetworkspawn
branch
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
… correctly to clients as initialization and not delta (Unity-Technologies#1266) Co-authored-by: Matt Walsh <69258106+mattwalsh-unity@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure server netvar initialization in OnNetworkSpawn replicates correctly to clients as initialization and not delta
MTT-1351
Changelog
com.unity.netcode.gameobjects
Testing and Documentation