-
Notifications
You must be signed in to change notification settings - Fork 450
refactor!: remove network dictionary & set, use native container in List, add tests #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mattwalsh-unity
merged 21 commits into
develop
from
refactor/simplify_collection_interfaces
Sep 14, 2021
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
2e1551a
refactor!: clean up network dictionary, use native containers
mattwalsh-unity 371869d
readonly missing
mattwalsh-unity 6e4ede6
added dirty list as native container
mattwalsh-unity eb7c24f
NetworkSet ported to native
mattwalsh-unity cf7707c
improved destroy
mattwalsh-unity 5b52d11
remove set & dictionary
mattwalsh-unity 9351b6d
list cleanup
mattwalsh-unity fcfa217
more tests
mattwalsh-unity 4213ae8
lint cleanup
mattwalsh-unity 9746836
Fixing NetworkList tests from throwing
andrews-unity 34f4c23
cleanup improvements, nativeList for dirty event list
mattwalsh-unity a280d04
test cleanup
mattwalsh-unity b32f493
Merge branch 'develop' into refactor/simplify_collection_interfaces
mattwalsh-unity 33df729
rounded out xtors in NetworkList
mattwalsh-unity 161f10e
improved ienumerable, removed client writability
mattwalsh-unity c7d6301
header cleanup
mattwalsh-unity 42566af
now -> index
mattwalsh-unity 3c5f22c
Merge branch 'develop' into refactor/simplify_collection_interfaces
mattwalsh-unity e2b55a7
server -> client
mattwalsh-unity b3cffbf
Merge branch 'refactor/simplify_collection_interfaces' of github.com:…
mattwalsh-unity 1b2c343
Merge branch 'develop' into refactor/simplify_collection_interfaces
mattwalsh-unity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, there is something weird on why - in tests anyway - we instantiate a NB band then ditch it before we ever call InitializeVariables. But regardless, we are now saying that Netvars need a chance to be disposed, and this ensures we don't skip any. There are certainly better ways to register the netvars than the scan in InitializeVariables which we can look at later which might eliminate the need for this