fix: snapshot system. last fixes for release #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the sent info) from preparing the buffer to send
…t in the specified limit, instead of stopping once the limit is busted
…pawns are limited in message size
…hot-system-spawn4
…hot-system-spawn4
…hot-system-spawn4
…Otherwise it grows unbound
…aves it disabled
…hot-system-spawn4
LukeStampfli
reviewed
Sep 2, 2021
| @@ -1067,5 +1118,37 @@ private void DebugDisplayStore() | |||
| table += "======\n"; | |||
| Debug.Log(table); | |||
| } | |||
|
|
|||
| static internal SnapshotDespawnCommand GetDespawnCommand() | |||
There was a problem hiding this comment.
I don't see what this does. The struct constructor already initializes everything as default.
There was a problem hiding this comment.
Like this is a struct it will not pass the static instance by reference here.
There was a problem hiding this comment.
Right. After re-trying seems like I was confused with C++ (again).
Was using SnapshotDespawnCommand command; instead of
SnapshotDespawnCommand command = new SnapshotDespawnCommand();
will fix.
There was a problem hiding this comment.
You can also do SnapshotDespawnCommand command = default (will do exactly the same as default constructor)
LukeStampfli
reviewed
Sep 2, 2021
| var diff = Math.Min(63, m_CurrentTick - spawnCommand.TickWritten); | ||
|
|
||
| // -1 to make the first resend immediate | ||
| return (1 << diff) > (spawnCommand.TimesWritten - 1); |
LukeStampfli
approved these changes
Sep 2, 2021
SamuelBellomo
added a commit
that referenced
this pull request
Sep 3, 2021
…hub.com:Unity-Technologies/com.unity.multiplayer.mlapi into sam/feature/interpolation-for-network-transform * 'sam/feature/interpolation-for-network-transform' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi: fix: networkscenemanager not releasing buffers from pool (#1132) test: fixed-length strings in netvars (#1119) fix: snapshot system. last fixes for release (#1129) refactor!: Unified Shutdown (#1108) chore: Fill out unity project for integration test project (#1128) feat: make ServerRpc ownership check an error log instead of warning log (#1126)
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
* feat: snapshot. MTT-1087 first part. separating the side effect (storing the sent info) from preparing the buffer to send * feat: snapshot. MTT-1087 second part. Writing SnapshotMessage that fit in the specified limit, instead of stopping once the limit is busted * feat: snapshot. MTT-1087 part 3. Writing spawns after acks, because spawns are limited in message size * feat: snapshot. MTT-1087 part 4. Using max spawn message size from NetworkConfig * feat: snapshot. mtt-1087. Forgotten , for performance * feat: snapshot. MTT-1089 pessimistic resend control. spawn part * feat: snapshot. MTT-1089 pessimistic resend control. despawn part * fix: snapshot. Cleaning up our clientData.SentSpawns data structure. Otherwise it grows unbound * feat: snapshot. Last fixes for release. Prepares for MTT-1089, but leaves it disabled * feat: snapshot. Last fixes for release. PR review comments * style: snapshot. Coding standards * style: snapshot. Coding standards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
GetSpawnCommand'GetDespawnCommand` to get default-constructed structs. Makes the code lighter and protects the code from needing to change when a field is added to those structs.Keeps track of how many time a spawn was written to a message. Will be needed for controlling re-sends, but not used for now.
Empties the
SentSpawnarray, when spawns and despawns are ack'ed. It would grow unbound otherwise.That should be it for SnapshotSystem for this release. :-)