Skip to content

fix: MTT-1124 Counters are now reported in sync with other metrics #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2021
Merged

fix: MTT-1124 Counters are now reported in sync with other metrics #1096

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6b61b0
fix: MTT-1124 Counters are now reported in sync with other metrics
Aug 26, 2021
d385ae5
Merge branch 'develop' into bugfix/MTT-1124_counters_delayed_netstat_…
Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,8 +1054,6 @@ public void NetworkUpdate(NetworkUpdateStage updateStage)

private void OnNetworkEarlyUpdate()
{
NetworkMetrics.DispatchFrame();

if (IsListening)
{
#if DEVELOPMENT_BUILD || UNITY_EDITOR
Expand Down Expand Up @@ -1116,6 +1114,8 @@ private void OnNetworkManagerTick()
{
SyncTime();
}

NetworkMetrics.DispatchFrame();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to add a unit test to validate the moment at which the metrics are dispatched?

}

private void SendConnectionRequest()
Expand Down