Skip to content

chore!: remove netvar predefined types #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

mattwalsh-unity
Copy link
Contributor

These pre-defined types are no longer necessary with our supported Unity versions, and actually are in conflict with the client network variable change (that is we could only have a NetworkVariableBool but not a ClientNetworkBool without duplicating all these types)

Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome sauce!
Using types makes things easier...LGTM!

@mattwalsh-unity mattwalsh-unity merged commit 2017e0f into develop Aug 25, 2021
@mattwalsh-unity mattwalsh-unity deleted the feature/netvar_cleanup_pass branch August 25, 2021 23:27
mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants