Addressed most of the review feedback. Still need to do a little more…

… restructuring of some of the other tests.

com.unity.netcode.gameobjects/Runtime/Serialization/BitReader.cs

@@ -65,7 +65,7 @@ public void Dispose()
         /// </summary>
         /// <param name="bitCount">Number of bits you want to read, in total</param>
         /// <returns>True if you can read, false if that would exceed buffer bounds</returns>
-        public bool VerifyCanReadBits(int bitCount)
+        public bool TryBeginReadBits(uint bitCount)
         {
             var newBitPosition = m_BitPosition + bitCount;
             var totalBytesWrittenInBitwiseContext = newBitPosition >> 3;
@@ -80,7 +80,7 @@ public bool VerifyCanReadBits(int bitCount)
                 return false;
             }
 #if DEVELOPMENT_BUILD || UNITY_EDITOR
-            m_AllowedBitwiseReadMark = newBitPosition;
+            m_AllowedBitwiseReadMark = (int)newBitPosition;
 #endif
             return true;
         }
@@ -90,7 +90,7 @@ public bool VerifyCanReadBits(int bitCount)
         /// </summary>
         /// <param name="value">Value to store bits into.</param>
         /// <param name="bitCount">Amount of bits to read</param>
-        public unsafe void ReadBits(out ulong value, int bitCount)
+        public unsafe void ReadBits(out ulong value, uint bitCount)
         {
 #if DEVELOPMENT_BUILD || UNITY_EDITOR
             if (bitCount > 64)
@@ -103,15 +103,15 @@ public unsafe void ReadBits(out ulong value, int bitCount)
                 throw new ArgumentOutOfRangeException(nameof(bitCount), "Cannot read fewer than 0 bits!");
             }
 
-            int checkPos = (m_BitPosition + bitCount);
+            int checkPos = (int)(m_BitPosition + bitCount);
             if (checkPos > m_AllowedBitwiseReadMark)
             {
-                throw new OverflowException("Attempted to read without first calling VerifyCanReadBits()");
+                throw new OverflowException("Attempted to read without first calling TryBeginReadBits()");
             }
 #endif
             ulong val = 0;
 
-            int wholeBytes = bitCount / k_BitsPerByte;
+            int wholeBytes = (int)bitCount / k_BitsPerByte;
             byte* asBytes = (byte*)&val;
             if (BitAligned)
             {
@@ -128,7 +128,7 @@ public unsafe void ReadBits(out ulong value, int bitCount)
                 }
             }
 
-            val |= (ulong)ReadByteBits(bitCount & 7) << (bitCount & ~7);
+            val |= (ulong)ReadByteBits((int)bitCount & 7) << ((int)bitCount & ~7);
             value = val;
         }
 
@@ -137,16 +137,16 @@ public unsafe void ReadBits(out ulong value, int bitCount)
         /// </summary>
         /// <param name="value">Value to store bits into.</param>
         /// <param name="bitCount">Amount of bits to read.</param>
-        public void ReadBits(out byte value, int bitCount)
+        public void ReadBits(out byte value, uint bitCount)
         {
 #if DEVELOPMENT_BUILD || UNITY_EDITOR
-            int checkPos = (m_BitPosition + bitCount);
+            int checkPos = (int)(m_BitPosition + bitCount);
             if (checkPos > m_AllowedBitwiseReadMark)
             {
-                throw new OverflowException("Attempted to read without first calling VerifyCanReadBits()");
+                throw new OverflowException("Attempted to read without first calling TryBeginReadBits()");
             }
 #endif
-            value = ReadByteBits(bitCount);
+            value = ReadByteBits((int)bitCount);
         }
 
         /// <summary>
@@ -160,7 +160,7 @@ public unsafe void ReadBit(out bool bit)
             int checkPos = (m_BitPosition + 1);
             if (checkPos > m_AllowedBitwiseReadMark)
             {
-                throw new OverflowException("Attempted to read without first calling VerifyCanReadBits()");
+                throw new OverflowException("Attempted to read without first calling TryBeginReadBits()");
             }
 #endif
 

com.unity.netcode.gameobjects/Runtime/Serialization/BitWriter.cs

@@ -55,15 +55,20 @@ public void Dispose()
         }
 
         /// <summary>
-        /// Verifies the requested bit count can be written to the buffer.
-        /// This exists as a separate method to allow multiple bit writes to be bounds checked with a single call.
-        /// If it returns false, you may not write, and in editor and development builds, attempting to do so will
-        /// throw an exception. In release builds, attempting to do so will write to random memory addresses and cause
-        /// Bad Things(TM).
+        /// Allows faster serialization by batching bounds checking.
+        /// When you know you will be writing multiple fields back-to-back and you know the total size,
+        /// you can call TryBeginWriteBits() once on the total size, and then follow it with calls to
+        /// WriteBit() or WriteBits().
+        /// 
+        /// Bitwise write operations will throw OverflowException in editor and development builds if you
+        /// go past the point you've marked using TryBeginWriteBits(). In release builds, OverflowException will not be thrown
+        /// for performance reasons, since the point of using TryBeginWrite is to avoid bounds checking in the following
+        /// operations in release builds. Instead, attempting to write past the marked position in release builds
+        /// will write to random memory and cause undefined behavior, likely including instability and crashes.
         /// </summary>
         /// <param name="bitCount">Number of bits you want to write, in total</param>
         /// <returns>True if you can write, false if that would exceed buffer bounds</returns>
-        public unsafe bool VerifyCanWriteBits(int bitCount)
+        public unsafe bool TryBeginWriteBits(int bitCount)
         {
             var newBitPosition = m_BitPosition + bitCount;
             var totalBytesWrittenInBitwiseContext = newBitPosition >> 3;
@@ -96,27 +101,22 @@ public unsafe bool VerifyCanWriteBits(int bitCount)
         /// </summary>
         /// <param name="value">Value to get bits from.</param>
         /// <param name="bitCount">Amount of bits to write</param>
-        public unsafe void WriteBits(ulong value, int bitCount)
+        public unsafe void WriteBits(ulong value, uint bitCount)
         {
 #if DEVELOPMENT_BUILD || UNITY_EDITOR
             if (bitCount > 64)
             {
                 throw new ArgumentOutOfRangeException(nameof(bitCount), "Cannot write more than 64 bits from a 64-bit value!");
             }
 
-            if (bitCount < 0)
-            {
-                throw new ArgumentOutOfRangeException(nameof(bitCount), "Cannot write fewer than 0 bits!");
-            }
-
-            int checkPos = (m_BitPosition + bitCount);
+            int checkPos = (int)(m_BitPosition + bitCount);
             if (checkPos > m_AllowedBitwiseWriteMark)
             {
-                throw new OverflowException("Attempted to write without first calling FastBufferWriter.VerifyCanWriteBits()");
+                throw new OverflowException("Attempted to write without first calling FastBufferWriter.TryBeginWriteBits()");
             }
 #endif
 
-            int wholeBytes = bitCount / k_BitsPerByte;
+            int wholeBytes = (int)bitCount / k_BitsPerByte;
             byte* asBytes = (byte*)&value;
             if (BitAligned)
             {
@@ -144,13 +144,13 @@ public unsafe void WriteBits(ulong value, int bitCount)
         /// </summary>
         /// <param name="value">Value to get bits from.</param>
         /// <param name="bitCount">Amount of bits to write.</param>
-        public void WriteBits(byte value, int bitCount)
+        public void WriteBits(byte value, uint bitCount)
         {
 #if DEVELOPMENT_BUILD || UNITY_EDITOR
-            int checkPos = (m_BitPosition + bitCount);
+            int checkPos = (int)(m_BitPosition + bitCount);
             if (checkPos > m_AllowedBitwiseWriteMark)
             {
-                throw new OverflowException("Attempted to write without first calling FastBufferWriter.VerifyCanWriteBits()");
+                throw new OverflowException("Attempted to write without first calling FastBufferWriter.TryBeginWriteBits()");
             }
 #endif
 
@@ -171,7 +171,7 @@ public unsafe void WriteBit(bool bit)
             int checkPos = (m_BitPosition + 1);
             if (checkPos > m_AllowedBitwiseWriteMark)
             {
-                throw new OverflowException("Attempted to write without first calling FastBufferWriter.VerifyCanWriteBits()");
+                throw new OverflowException("Attempted to write without first calling FastBufferWriter.TryBeginWriteBits()");
             }
 #endif
 

com.unity.netcode.gameobjects/Runtime/Serialization/BufferSerializerReader.cs

@@ -78,7 +78,7 @@ public void SerializeNetworkSerializable<T>(ref T value) where T : INetworkSeria
 
         public bool PreCheck(int amount)
         {
-            return m_Reader.Value.VerifyCanRead(amount);
+            return m_Reader.Value.TryBeginRead(amount);
         }
 
         public void SerializeValuePreChecked(ref GameObject value)

com.unity.netcode.gameobjects/Runtime/Serialization/BufferSerializerWriter.cs

@@ -78,7 +78,7 @@ public void SerializeNetworkSerializable<T>(ref T value) where T : INetworkSeria
 
         public bool PreCheck(int amount)
         {
-            return m_Writer.Value.VerifyCanWrite(amount);
+            return m_Writer.Value.TryBeginWrite(amount);
         }
 
         public void SerializeValuePreChecked(ref GameObject value)

com.unity.netcode.gameobjects/Runtime/Serialization/BytePacker.cs

@@ -98,7 +98,7 @@ public static void WriteObjectPacked(ref FastBufferWriter writer, object value,
             }
             if (value is GameObject)
             {
-                var networkObject = ((GameObject)value).GetComponent<NetworkObject>();
+                ((GameObject)value).TryGetComponent<NetworkObject>(out var networkObject);
                 if (networkObject == null)
                 {
                     throw new ArgumentException($"{nameof(NetworkWriter)} cannot write {nameof(GameObject)} types that does not has a {nameof(NetworkObject)} component attached. {nameof(GameObject)}: {((GameObject)value).name}");
@@ -453,15 +453,15 @@ public static void WriteValueBitPacked(ref FastBufferWriter writer, ushort value
 
             if (value <= 0b0111_1111)
             {
-                if (!writer.VerifyCanWriteInternal(1))
+                if (!writer.TryBeginWriteInternal(1))
                 {
                     throw new OverflowException("Writing past the end of the buffer");
                 }
                 writer.WriteByte((byte)(value << 1));
                 return;
             }
 
-            if (!writer.VerifyCanWriteInternal(2))
+            if (!writer.TryBeginWriteInternal(2))
             {
                 throw new OverflowException("Writing past the end of the buffer");
             }
@@ -501,7 +501,7 @@ public static void WriteValueBitPacked(ref FastBufferWriter writer, uint value)
 #endif
             value <<= 2;
             var numBytes = BitCounter.GetUsedByteCount(value);
-            if (!writer.VerifyCanWriteInternal(numBytes))
+            if (!writer.TryBeginWriteInternal(numBytes))
             {
                 throw new OverflowException("Writing past the end of the buffer");
             }
@@ -541,7 +541,7 @@ public static void WriteValueBitPacked(ref FastBufferWriter writer, ulong value)
 #endif
             value <<= 3;
             var numBytes = BitCounter.GetUsedByteCount(value);
-            if (!writer.VerifyCanWriteInternal(numBytes))
+            if (!writer.TryBeginWriteInternal(numBytes))
             {
                 throw new OverflowException("Writing past the end of the buffer");
             }
@@ -566,7 +566,7 @@ private static void WriteUInt64Packed(ref FastBufferWriter writer, ulong value)
             }
             var writeBytes = BitCounter.GetUsedByteCount(value);
 
-            if (!writer.VerifyCanWriteInternal(writeBytes + 1))
+            if (!writer.TryBeginWriteInternal(writeBytes + 1))
             {
                 throw new OverflowException("Writing past the end of the buffer");
             }
@@ -592,7 +592,7 @@ private static void WriteUInt32Packed(ref FastBufferWriter writer, uint value)
             }
             var writeBytes = BitCounter.GetUsedByteCount(value);
 
-            if (!writer.VerifyCanWriteInternal(writeBytes + 1))
+            if (!writer.TryBeginWriteInternal(writeBytes + 1))
             {
                 throw new OverflowException("Writing past the end of the buffer");
             }

com.unity.netcode.gameobjects/Runtime/Serialization/ByteUnpacker.cs

@@ -466,7 +466,7 @@ public static unsafe void ReadValueBitPacked(ref FastBufferReader reader, out us
             byte* ptr = ((byte*)&returnValue);
             byte* data = reader.GetUnsafePtrAtCurrentPosition();
             int numBytes = (data[0] & 0b1) + 1;
-            if (!reader.VerifyCanReadInternal(numBytes))
+            if (!reader.TryBeginReadInternal(numBytes))
             {
                 throw new OverflowException("Reading past the end of the buffer");
             }
@@ -511,7 +511,7 @@ public static unsafe void ReadValueBitPacked(ref FastBufferReader reader, out ui
             byte* ptr = ((byte*)&returnValue);
             byte* data = reader.GetUnsafePtrAtCurrentPosition();
             int numBytes = (data[0] & 0b11) + 1;
-            if (!reader.VerifyCanReadInternal(numBytes))
+            if (!reader.TryBeginReadInternal(numBytes))
             {
                 throw new OverflowException("Reading past the end of the buffer");
             }
@@ -565,7 +565,7 @@ public static unsafe void ReadValueBitPacked(ref FastBufferReader reader, out ul
             byte* ptr = ((byte*)&returnValue);
             byte* data = reader.GetUnsafePtrAtCurrentPosition();
             int numBytes = (data[0] & 0b111) + 1;
-            if (!reader.VerifyCanReadInternal(numBytes))
+            if (!reader.TryBeginReadInternal(numBytes))
             {
                 throw new OverflowException("Reading past the end of the buffer");
             }
@@ -649,7 +649,7 @@ private static void ReadUInt64Packed(ref FastBufferReader reader, out ulong valu
             }
 
             var numBytes = firstByte - 247;
-            if (!reader.VerifyCanReadInternal(numBytes))
+            if (!reader.TryBeginReadInternal(numBytes))
             {
                 throw new OverflowException("Reading past the end of the buffer");
             }
@@ -673,7 +673,7 @@ private static void ReadUInt32Packed(ref FastBufferReader reader, out uint value
             }
 
             var numBytes = firstByte - 247;
-            if (!reader.VerifyCanReadInternal(numBytes))
+            if (!reader.TryBeginReadInternal(numBytes))
             {
                 throw new OverflowException("Reading past the end of the buffer");
             }