feat: snapshot. Fully integrated despawn, mtt-1092, mtt-1056

com.unity.netcode.gameobjects/Runtime/Configuration/NetworkConfig.cs

@@ -160,8 +160,8 @@ public class NetworkConfig
 
         // todo: transitional. For the next release, only Snapshot should remain
         // The booleans allow iterative development and testing in the meantime
-        public bool UseSnapshotDelta = false;
-        public bool UseSnapshotSpawn = false;
+        public bool UseSnapshotDelta { get; } = false;
+        public bool UseSnapshotSpawn { get; } = false;
 
         public const int RttAverageSamples = 5; // number of RTT to keep an average of (plus one)
         public const int RttWindowSize = 64; // number of slots to use for RTT computations (max number of in-flight packets)

com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs

@@ -417,7 +417,7 @@ private void Initialize(bool server)
                 SnapshotSystem = null;
             }
 
-            SnapshotSystem = new SnapshotSystem();
+            SnapshotSystem = new SnapshotSystem(this);
 
             if (server)
             {

com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

@@ -234,6 +234,11 @@ public void NetworkShow(ulong clientId)
                 throw new VisibilityChangeException("The object is already visible");
             }
 
+            if (NetworkManager.NetworkConfig.UseSnapshotSpawn)
+            {
+                SnapshotSpawn(clientId);
+            }
+
             Observers.Add(clientId);
 
             NetworkManager.SpawnManager.SendSpawnCallForObject(clientId, OwnerClientId, this);
@@ -310,23 +315,30 @@ public void NetworkHide(ulong clientId)
             }
 
 
-            // Send destroy call
             Observers.Remove(clientId);
 
-            var context = NetworkManager.MessageQueueContainer.EnterInternalCommandContext(
-                MessageQueueContainer.MessageType.DestroyObject, NetworkChannel.Internal,
-                new[] { clientId }, NetworkUpdateStage.PostLateUpdate);
-            if (context != null)
+            if (NetworkManager.NetworkConfig.UseSnapshotSpawn)
             {
-                using (var nonNullContext = (InternalCommandContext)context)
+                SnapshotDespawn(clientId);
+            }
+            else
+            {
+                // Send destroy call
+                var context = NetworkManager.MessageQueueContainer.EnterInternalCommandContext(
+                    MessageQueueContainer.MessageType.DestroyObject, NetworkChannel.Internal,
+                    new[] { clientId }, NetworkUpdateStage.PostLateUpdate);
+                if (context != null)
                 {
-                    var bufferSizeCapture = new CommandContextSizeCapture(nonNullContext);
-                    bufferSizeCapture.StartMeasureSegment();
+                    using (var nonNullContext = (InternalCommandContext)context)
+                    {
+                        var bufferSizeCapture = new CommandContextSizeCapture(nonNullContext);
+                        bufferSizeCapture.StartMeasureSegment();
 
-                    nonNullContext.NetworkWriter.WriteUInt64Packed(NetworkObjectId);
+                        nonNullContext.NetworkWriter.WriteUInt64Packed(NetworkObjectId);
 
-                    var size = bufferSizeCapture.StopMeasureSegment();
-                    NetworkManager.NetworkMetrics.TrackObjectDestroySent(clientId, NetworkObjectId, name, size);
+                        var size = bufferSizeCapture.StopMeasureSegment();
+                        NetworkManager.NetworkMetrics.TrackObjectDestroySent(clientId, NetworkObjectId, name, size);
+                    }
                 }
             }
         }
@@ -405,6 +417,74 @@ private void OnDestroy()
             }
         }
 
+        private SnapshotDespawnCommand GetDespawnCommand()
+        {
+            SnapshotDespawnCommand command;
+            command.NetworkObjectId = NetworkObjectId;
+            command.TickWritten = default; // value will be set internally by SnapshotSystem
+            command.TargetClientIds = default;
+
+            return command;
+        }
+
+        private SnapshotSpawnCommand GetSpawnCommand()
+        {
+            SnapshotSpawnCommand command;
+            command.NetworkObjectId = NetworkObjectId;
+            command.OwnerClientId = OwnerClientId;
+            command.IsPlayerObject = IsPlayerObject;
+            command.IsSceneObject = (IsSceneObject == null) || IsSceneObject.Value;
+
+            ulong? parent = NetworkManager.SpawnManager.GetSpawnParentId(this);
+            if (parent != null)
+            {
+                command.ParentNetworkId = parent.Value;
+            }
+            else
+            {
+                // write own network id, when no parents. todo: optimize this.
+                command.ParentNetworkId = command.NetworkObjectId;
+            }
+
+            command.GlobalObjectIdHash = HostCheckForGlobalObjectIdHashOverride();
+            // todo: check if (IncludeTransformWhenSpawning == null || IncludeTransformWhenSpawning(clientId)) for any clientId
+            command.ObjectPosition = transform.position;
+            command.ObjectRotation = transform.rotation;
+            command.ObjectScale = transform.localScale;
+            command.TickWritten = default; // value will be set internally by SnapshotSystem
+            command.TargetClientIds = default;
+
+            return command;
+        }
+
+        private void SnapshotSpawn()
+        {
+            var command = GetSpawnCommand();
+            NetworkManager.SnapshotSystem.Spawn(command);
+        }
+
+        private void SnapshotSpawn(ulong clientId)
+        {
+            var command = GetSpawnCommand();
+            command.TargetClientIds = new List<ulong>();
+            command.TargetClientIds.Add(clientId);
+            NetworkManager.SnapshotSystem.Spawn(command);
+        }
+
+        internal void SnapshotDespawn()
+        {
+            var command = GetDespawnCommand();
+            NetworkManager.SnapshotSystem.Despawn(command);
+        }
+
+        internal void SnapshotDespawn(ulong clientId)
+        {
+            var command = GetDespawnCommand();
+            command.TargetClientIds = new List<ulong>();
+            command.TargetClientIds.Add(clientId);
+            NetworkManager.SnapshotSystem.Despawn(command);
+        }
+
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         private void SpawnInternal(bool destroyWithScene, ulong? ownerClientId, bool playerObject)
         {
@@ -422,32 +502,7 @@ private void SpawnInternal(bool destroyWithScene, ulong? ownerClientId, bool pla
 
             if (NetworkManager.NetworkConfig.UseSnapshotSpawn)
             {
-                SnapshotSpawnCommand command;
-                command.NetworkObjectId = NetworkObjectId;
-                command.OwnerClientId = OwnerClientId;
-                command.IsPlayerObject = IsPlayerObject;
-                command.IsSceneObject = (IsSceneObject == null) || IsSceneObject.Value;
-
-                ulong? parent = NetworkManager.SpawnManager.GetSpawnParentId(this);
-                if (parent != null)
-                {
-                    command.ParentNetworkId = parent.Value;
-                }
-                else
-                {
-                    // write own network id, when no parents. todo: optimize this.
-                    command.ParentNetworkId = command.NetworkObjectId;
-                }
-
-                command.GlobalObjectIdHash = HostCheckForGlobalObjectIdHashOverride();
-                // todo: check if (IncludeTransformWhenSpawning == null || IncludeTransformWhenSpawning(clientId)) for any clientId
-                command.ObjectPosition = transform.position;
-                command.ObjectRotation = transform.rotation;
-                command.ObjectScale = transform.localScale;
-                command.TickWritten = 0; // will be reset in Spawn
-                command.TargetClientIds = default;
-
-                NetworkManager.SnapshotSystem.Spawn(command);
+                SnapshotSpawn();
             }
 
             ulong ownerId = ownerClientId != null ? ownerClientId.Value : NetworkManager.ServerClientId;