Skip to content

Avoid string allocation #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Avoid string allocation #1043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion com.unity.multiplayer.mlapi/Runtime/Core/NetworkBehaviour.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,8 @@ internal void InitializeVariables()
instance.SetNetworkBehaviour(this);

var instanceNameProperty = fieldType.GetProperty(nameof(INetworkVariable.Name));
instanceNameProperty?.SetValue(instance, sortedFields[i].Name);
var sanitizedVariableName = sortedFields[i].Name.Replace("<", string.Empty).Replace(">k__BackingField", string.Empty);
instanceNameProperty?.SetValue(instance, sanitizedVariableName);

NetworkVariableFields.Add(instance);
}
Expand Down
8 changes: 1 addition & 7 deletions com.unity.multiplayer.mlapi/Runtime/Metrics/NetworkMetrics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using Unity.Multiplayer.NetStats.Dispatch;
using Unity.Multiplayer.NetStats.Metrics;
using Unity.Multiplayer.NetStatsReporting;
using UnityEngine.Profiling;

namespace Unity.Netcode
{
Expand Down Expand Up @@ -92,13 +93,11 @@ public void TrackUnnamedMessageReceived(ulong senderClientId, long bytesCount)

public void TrackNetworkVariableDeltaSent(ulong receiverClientId, ulong networkObjectId, string gameObjectName, string variableName, long bytesCount)
{
variableName = PrettyPrintVariableName(variableName);
m_NetworkVariableDeltaSentEvent.Mark(new NetworkVariableEvent(new ConnectionInfo(receiverClientId), new NetworkObjectIdentifier(gameObjectName, networkObjectId), variableName, bytesCount));
}

public void TrackNetworkVariableDeltaReceived(ulong senderClientId, ulong networkObjectId, string gameObjectName, string variableName, long bytesCount)
{
variableName = PrettyPrintVariableName(variableName);
m_NetworkVariableDeltaReceivedEvent.Mark(new NetworkVariableEvent(new ConnectionInfo(senderClientId), new NetworkObjectIdentifier(gameObjectName, networkObjectId), variableName, bytesCount));
}

Expand Down Expand Up @@ -183,11 +182,6 @@ public void DispatchFrame()
{
Dispatcher.Dispatch();
}

private static string PrettyPrintVariableName(string variableName)
{
return variableName.Replace("<", string.Empty).Replace(">k__BackingField", string.Empty);
}
}

public class MLAPIObserver
Expand Down