Skip to content

feat: Adding channels for those that just want to know what they do. #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: Adding channels for those that just want to know what they do. #1029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions com.unity.multiplayer.mlapi/Runtime/Transports/NetworkTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ public enum NetworkChannel : byte
NetworkVariable, //todo: this channel will be used for snapshotting and should then go from reliable to unreliable
SnapshotExchange,
Fragmented,
ReliableSequenced,
ReliableUnsequenced,
ReliableFragmentedSequenced,
UnreliableSequenced,
UnreliableUnsequenced,
Comment on lines +22 to +26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I believe we're planning to get rid of the explicit transport QoS channel specification as a whole soon :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, really soon :)

ChannelUnused, // <<-- must be present, and must be last
};

Expand Down Expand Up @@ -108,6 +113,12 @@ public TransportChannel[] NETCODE_CHANNELS

new TransportChannel(NetworkChannel.Fragmented, NetworkDelivery.ReliableFragmentedSequenced),

// Channels for those that just want to know exactly what it is
new TransportChannel(NetworkChannel.UnreliableSequenced, NetworkDelivery.UnreliableSequenced),
new TransportChannel(NetworkChannel.UnreliableUnsequenced, NetworkDelivery.Unreliable),
new TransportChannel(NetworkChannel.ReliableSequenced, NetworkDelivery.ReliableSequenced),
new TransportChannel(NetworkChannel.ReliableUnsequenced, NetworkDelivery.Reliable),
new TransportChannel(NetworkChannel.ReliableFragmentedSequenced, NetworkDelivery.ReliableFragmentedSequenced),
};

/// <summary>
Expand Down