refactor!: remove spawn payload technical debt #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the option to send a payload when spawning an object. The primary reason for this is that we do not save the payload data on a per NetworkObject instance basis and if a user were to use the spawn payload parameter that included data that was required to set any specific states of a NetworkObject or associated components then late joining players would not receive the payload information and would become out of sych with the game.
Needed more than 1 commit and left out a few checks for payload when reading as well as removed XML Doc parameters that referred to "payload".
jeffreyrainy
approved these changes
Aug 2, 2021
mattwalsh-unity
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove the option to send a payload when spawning an object.
The primary reason for this is that we do not save the payload data on a per NetworkObject instance basis and if a user were to use the spawn payload parameter that included data that was required to set any specific states of a NetworkObject or associated components then late joining players would not receive the payload information and would become out of sych with the game.
Associated Jira Technical Debt Ticket: MTT-982