ChangeOwnership gives KeyNotFoundException on the connected client

[goudcode]

Describe the bug
ChangeOwnership gives KeyNotFoundException on the connected client

To Reproduce

1. Make a prefab with a NetworkObject and NetworkTransform component
2. Instantiate it on the server.
3. Spawn the NetworkObject component
4. Change ownership on the NetworkObject to the client
5. Client gets exception

Expected behavior
Ownership transferred to the client

Screenshots
Spawning code on the server

Exception on the client

Environment (please complete the following information):

• OS: Windows 10
• Unity Version: 2020.3
• MLAPI Version (package): 0.1.0
• MLAPI Commit: 3e3aef6

[goudcode]

It appeared to be a race condition, changed the ownership in the same frame as spawning causes the client to not have the object yet.

Closing

[LukeStampfli]

Reopening this as it is still a bug and needs to be fixed.

For anyone else running in this issue SpawnWithOwnership can be used for now to circumvent this issue easily.

[will-mearns]

Created MTT-579 for tracking this issue

[0xFA11]

I think the exception is coming from NetworkManager.Singleton.ConnectedClients.Last().Key statement.
I wonder where this code is being executed at, client or server/host? @goudcode

[NoelStephensUnity]

Hello goudcode!

This is a great find and this issue is being reviewed for a potentially better solution that won't result in the KeyNotFoundException.

However, you can resolve this issue in MLAPI v0.1.0 by using one of the two methods within NetworkObject:
public void SpawnWithOwnership(ulong clientId, Stream spawnPayload = null, bool destroyWithScene = false)
public void SpawnAsPlayerObject(ulong clientId, Stream spawnPayload = null, bool destroyWithScene = false)

If you are spawning players, then it is recommend (for v0.1.0) to use NetworkObject.SpawnAsPlayerObject.
If you are spawning GameObjects that require player ownership then it is recommend (for v0.1.0) to use NetworkObject.SpawnWithOwnership.

Let me know if this resolves the issue for you while using v0.1.0?

[goudcode]

@MFatihMAR That statement was being executed on the Server.

@NoelStephensUnity Using SpawnWithOwnership indeed solved my issue.