Call OnClientConnectedCallback when Host is created

[dbircsak]

When StartHost is called, a client is created, right? However OnClientConnectedCallback is not called. Could it be called for completeness?

[dbircsak]

StopHost doesn't call OnClientDisconnectCallback either

[onlinefrog]

I agree, I think most people would expect this behavior.

[CristianMR]

I'll let this here in case someone else is trying to figure out how to do it 😄

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using MLAPI;
using MLAPI.Configuration;

public class CustomNetworkingManager : NetworkingManager
{
    GameObject[] spawnPoints;

    void Start()
    {
        spawnPoints = GameObject.FindGameObjectsWithTag("SpawnPoint");
        Singleton.OnClientConnectedCallback += OnClientConnected;
        Singleton.OnServerStarted += ServerStarted;
    }

    void ServerStarted()
    {
        Debug.Log("Server started");

        if (IsHost) {
            OnClientConnected(ServerClientId);
        }
    }

    public void OnClientConnected (ulong clientId) {
        if (!IsServer) return;

        NetworkedPrefab playerPrefab = NetworkConfig.NetworkedPrefabs.Find(item => item.Prefab.name == "Player"); // I could search by Prefab.PlayerPrefab

        // get some spawn point
        Transform spawnPosition = spawnPoints[0].transform;

        GameObject player = Instantiate(playerPrefab.Prefab, spawnPosition.position, Quaternion.identity);

        player.GetComponent<NetworkedObject>().SpawnWithOwnership(clientId);
    }
}

[scott-lin]

I also ran into this confusing behavior and expected OnClientConnectedCallback to be called when the host is started since it's a client instance. I would actually consider this to be a bug, not an enhancement.

[TwoTenPvP]

This is fixed in develop.

#675