Incorrect behaviour when NetworkHide followed by NetworkShow

[ezoray]

Description

On a network object when a call made to NetworkHide is shortly followed by NetworkShow on the same object the object on the client is not despawned but is no long registered as a network object.

Reproduce Steps

Import and run the attached package.

Actual Outcome

On NetworkHide then NetworkShow the object on the client is not despawned on the client, and no longer has a network id.

Expected Outcome

Network object should be despawned and respawned.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

• OS: macOS Big Sur
• Unity Version: 2020 LTS
• Netcode Version: 1.0.0-pre.8

Additional Context

In a game project the object is left and a new one respawned, in the test code attached the object is left and not respawned.
ObservedObjectVisibilityBug.unitypackage.zip
.

[jeffreyrainy]

Thank you for the report. This is an interesting one.

Initial investigation:
Netcode.GameObjects relies on OnDestroy() on the GameObject to implement some of its functionality. Specifically:

            if (NetworkManager != null && NetworkManager.SpawnManager != null &&
                NetworkManager.SpawnManager.SpawnedObjects.TryGetValue(NetworkObjectId, out var networkObject))
            {
                NetworkManager.SpawnManager.OnDespawnObject(networkObject, false);
            }

This OnDespawnObject is triggered at end-of-frame. So, if NetworkHide and NetworkShow occur on the same frame, the object gets despawned again. We'll look for a fix but this will need some internal refactor.

[ezoray]

I figured it would be something along those lines, thanks for looking into it.

[will-mearns]

Tracking in jira as MTT-3488

[ezoray]

I'll close this now as it's fixed in pre9.