fix: spawners not working in case host exits

[fernando-cortez]

Description (*)

Jira task here.

If a host had exited the game abruptly while in-game, or had left while in the post-game screen, an exception was triggered on spawners which made them not spawn any imps on a subsequent playthrough.

This had to do with a static collection not being cleared on OnDisable(). This has been moved to both an OnNetworkDespawn() and OnDestroy(), as OnNetworkDespawn() is not guaranteed to be fired when the network is shutdown abruptly.

The same pattern was applied to a network text object that would not be cleared on a host exit event.

Related Pull Requests

Issue Number(s) (*)

Fixes issue(s): MTT-1472.

Manual testing scenarios

1. This was tested with Photon relay, in the editor as well as on standalone builds.
2. ...

Questions or comments

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[SamuelBellomo]

same here as this #397
Is there a fix incoming for this? @NoelStephensUnity please note we shouldn't fix things sample side that are going to get fixed soon by a new SDK update. Will a fix for this come in a 1.x soon?

[NoelStephensUnity]

@SamuelBellomo

same here as this #397 Is there a fix incoming for this? @NoelStephensUnity please note we shouldn't fix things sample side that are going to get fixed soon by a new SDK update. Will a fix for this come in a 1.x soon?

I replied in #397 with what I believe is the fix. Will look into Jira Ticket and have a Draft PR-1390 started.

[fernando-cortez]

PR status update: Fix has been merged with develop and included as part of pre.4 release.

Will simply review once SDK version is upgraded.

[fernando-cortez]

Closing this as the update here invalidates this PR.

OnDisable() is fired on NetworkBehaviours when a host abruptly shuts down the connected session, meaning that the PlayerServerCharacter collection is properly cleared between sessions. This then prevents any null objects inside of the player distance check inside of the enemy spawners.