Skip to content

[10.x.x] Merge Hdrp/staging [Skip CI] #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 97 commits into from
Jun 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
1df359c
WIP for enabling valid graphics tests with Render Graph.
JulienIgnace-Unity May 27, 2020
64ef0ca
Fixed more GCAlloc and added an option for a test to not be run if re…
JulienIgnace-Unity May 28, 2020
505924b
First batch of disabled tests.
JulienIgnace-Unity May 28, 2020
a6c1f8e
Fixed decal rendering
JulienIgnace-Unity May 28, 2020
04d0d20
Implemented ColorGrading and Uber Post (fixes a lot of small diff due…
JulienIgnace-Unity May 28, 2020
4934ab9
Revert "First batch of disabled tests."
JulienIgnace-Unity May 28, 2020
0dd42d8
Temp "texture not bound" error fix until bloom is implemented.
JulienIgnace-Unity May 28, 2020
027a5c5
Fixed an error when using a stale invalid renderer list handle.
JulienIgnace-Unity Jun 2, 2020
349a273
Add some debug info to compiled passes and removed wrong refCount++ o…
JulienIgnace-Unity Jun 2, 2020
a98f454
Merge branch 'HDRP/staging' of https://github.com/Unity-Technologies/…
JulienIgnace-Unity Jun 2, 2020
3eb0eb6
Added possibility to disallow pass pruning
JulienIgnace-Unity Jun 3, 2020
e1f9e08
Small fixes
JulienIgnace-Unity Jun 3, 2020
1213511
temporarily removed pruning of passes without product
JulienIgnace-Unity Jun 3, 2020
95952b0
Fixed HDRP asset for test 5009
JulienIgnace-Unity Jun 3, 2020
1d97a44
Implement alpha copy for post processes
JulienIgnace-Unity Jun 3, 2020
0c62ef7
Small render graph error fix for motion vector pass.
JulienIgnace-Unity Jun 3, 2020
84467f6
Disabled for render graph tests that are currently broken.
JulienIgnace-Unity Jun 4, 2020
7b8acc0
Updated yamato with new render graph configurations
JulienIgnace-Unity Jun 4, 2020
46a64a3
Fixed lens distortion
JulienIgnace-Unity Jun 4, 2020
76a7c00
Reenabled 4021
JulienIgnace-Unity Jun 4, 2020
9c4c38e
Added an option to ignore tests when render graph is enabled.
JulienIgnace-Unity Jun 4, 2020
e5d8dd0
Disabled for render graph tests that are currently broken.
JulienIgnace-Unity Jun 4, 2020
ec2a4af
Reenabled 4021
JulienIgnace-Unity Jun 4, 2020
399512c
Updated yamato script to add the RenderGraph pipeline.
JulienIgnace-Unity Jun 4, 2020
68fb303
Revert "Reenabled 4021"
JulienIgnace-Unity Jun 4, 2020
fb085d0
Revert "Updated yamato with new render graph configurations"
JulienIgnace-Unity Jun 4, 2020
b3ac299
Revert "Disabled for render graph tests that are currently broken."
JulienIgnace-Unity Jun 4, 2020
d0bb7fa
Reverted HDRP test framework files (will go to another PR)
JulienIgnace-Unity Jun 4, 2020
4ac6aa2
Revert "Fixed HDRP asset for test 5009"
JulienIgnace-Unity Jun 4, 2020
0e1d250
Fixed HDRP asset for test 5009
JulienIgnace-Unity Jun 3, 2020
ddd259e
Merge branch 'HDRP/staging' into HDRP/rendergraph-graphicstests
sebastienlagarde Jun 4, 2020
4d1cc10
Adding purge of unused resources in render graph.
JulienIgnace-Unity Jun 5, 2020
463fe5b
Merge branch 'HDRP/staging' of https://github.com/Unity-Technologies/…
JulienIgnace-Unity Jun 8, 2020
fc9f739
Revert unrelated yml files changes due to old configuration (#714)
theopnv Jun 8, 2020
01de7e6
Fixed an issue with not unregistering render graph debug.
JulienIgnace-Unity Jun 8, 2020
1fa7451
Disabled 9800 for render graph
JulienIgnace-Unity Jun 8, 2020
e05eb9a
Revert hdrp asset for 5009
JulienIgnace-Unity Jun 8, 2020
a09947a
Merge branch 'HDRP/rendergraph-enable-graphicstests' of https://githu…
JulienIgnace-Unity Jun 8, 2020
5fe9c4a
Merge branch 'HDRP/staging' of https://github.com/Unity-Technologies/…
JulienIgnace-Unity Jun 12, 2020
14a0cad
WIP Creation of compute buffers through render graph.
JulienIgnace-Unity Jun 8, 2020
4347974
Refactoring internal resource management to share more code (WIP)
JulienIgnace-Unity Jun 8, 2020
d126be4
Share most of the code between compute buffers and textures.
JulienIgnace-Unity Jun 15, 2020
10acf55
Restored internal API for tests and fixed unit tests.
JulienIgnace-Unity Jun 15, 2020
d738e28
need to switch repo
FrancescoC-unity Jun 16, 2020
f509b12
switching repo again :-)
FrancescoC-unity Jun 16, 2020
a38c2a2
Merge branch 'HDRP/staging' of https://github.com/Unity-Technologies/…
JulienIgnace-Unity Jun 16, 2020
1f5e7e0
Post merge fix
JulienIgnace-Unity Jun 16, 2020
489d2c9
Added APIs to create compute buffers through render graph.
JulienIgnace-Unity Jun 16, 2020
5486001
sync point (but it's broken :) )
FrancescoC-unity Jun 16, 2020
e6931fc
Refactor Light List build to use render graph created compute buffers.
JulienIgnace-Unity Jun 17, 2020
e4636d8
Small rewrite to facilitate implementing Probe Volume Light lists.
JulienIgnace-Unity Jun 17, 2020
8a2753d
Porting most to static fn pattern
FrancescoC-unity Jun 17, 2020
1a474fb
revert some bits of exposure (broken)
FrancescoC-unity Jun 17, 2020
d8e54f4
Merge branch 'HDRP/staging' into HDRP/post-processing-render-graph
FrancescoC-unity Jun 17, 2020
064a640
Refactored handle to include an intermediate ResourceHandle struct (n…
JulienIgnace-Unity Jun 17, 2020
3b0cb24
Fixed light list binding for forward passes.
JulienIgnace-Unity Jun 17, 2020
f8672b0
Removed usless SetGlobals
JulienIgnace-Unity Jun 17, 2020
0d75869
Correctly bind cluster buffers for transparent forward passes.
JulienIgnace-Unity Jun 17, 2020
2edc865
Fixed light list build (wrong light count)
JulienIgnace-Unity Jun 17, 2020
4695aad
Last touches
FrancescoC-unity Jun 18, 2020
d58328e
Rename h to hlsl
FrancescoC-unity Jun 18, 2020
a34aee2
changelog
FrancescoC-unity Jun 18, 2020
424855d
Fixed tile/cluster debug.
JulienIgnace-Unity Jun 18, 2020
473bca8
Merge remote-tracking branch 'origin/HDRP/staging' into HDRP/post-pro…
FrancescoC-unity Jun 18, 2020
b628507
Ported coarse stencil buffer to render graph.
JulienIgnace-Unity Jun 18, 2020
106320d
revert misalignment
FrancescoC-unity Jun 18, 2020
7d1681f
Moved decal property mask buffer to render graph created buffer.
JulienIgnace-Unity Jun 18, 2020
5a3d99f
Fixed reset size of width/height
JulienIgnace-Unity Jun 18, 2020
8e7aca7
Fix small issue when resizing window and improve compile time for deb…
FrancescoC-unity Jun 18, 2020
03af921
Revert compile time improvement... warning still there, makes no sense.
FrancescoC-unity Jun 18, 2020
49a908c
Fixed size of dbuffer property mask buffer.
JulienIgnace-Unity Jun 18, 2020
79da69b
avoid warning and prevent unrolling (improve compile time)
FrancescoC-unity Jun 18, 2020
c77e3ee
Merge pull request #967 from Unity-Technologies/HDRP/final-image-hist…
sebastienlagarde Jun 18, 2020
e5ee34d
Added scene view camera doc
JordanL8 Jun 18, 2020
aa5c854
Update TableOfContents.md
JordanL8 Jun 18, 2020
3b3ceb4
Add test scene for transparent depth pre & post pass
RemyUnity Jun 18, 2020
2c622a3
Merge pull request #978 from Unity-Technologies/HDRP/tests/pre-post-pass
sebastienlagarde Jun 18, 2020
314b501
Merge pull request #975 from Unity-Technologies/HDRP/docs/Scene-view-…
sebastienlagarde Jun 18, 2020
5c30a76
Merge pull request #961 from Unity-Technologies/HDRP/rename-cas-inclu…
sebastienlagarde Jun 18, 2020
0fd07af
Fixed unit tests
JulienIgnace-Unity Jun 19, 2020
f732507
Merge branch 'HDRP/staging' of https://github.com/Unity-Technologies/…
JulienIgnace-Unity Jun 19, 2020
bfcda7b
Merge pull request #963 from Unity-Technologies/HDRP/post-processing-…
sebastienlagarde Jun 19, 2020
6cf8c91
Fixed Receive SSR transparent nullref
alelievr Jun 19, 2020
dc97a6b
Fixed terrain and axf nullref
alelievr Jun 19, 2020
944cfac
Updated changelog
alelievr Jun 19, 2020
c46d266
Merge pull request #982 from Unity-Technologies/HDRP/fix/material-ui-…
sebastienlagarde Jun 19, 2020
cb8a7f3
Merge pull request #966 from Unity-Technologies/HDRP/rg-create-comput…
sebastienlagarde Jun 19, 2020
8feddb4
Hdrp Improved Depth Of Field (#965)
pmavridis Jun 19, 2020
b58a5d5
Merge branch 'master' into HDRP/staging
sebastienlagarde Jun 19, 2020
fcf02f0
Merge branch 'master' into HDRP/staging
sebastienlagarde Jun 19, 2020
91e14a5
Merge branch 'master' into HDRP/staging
sebastienlagarde Jun 19, 2020
ebdafa9
Fixed an issue where manipulating the color wheels in a volume compon…
JulienIgnace-Unity Jun 19, 2020
20b8fc9
Fixed an issue where static sky lighting would not be updated for a n…
JulienIgnace-Unity Jun 19, 2020
bd80b94
Update upgrade guide, fix hdrp resource asset and vfx (#992)
sebastienlagarde Jun 19, 2020
ca67aa3
Cleanup Render Pipeline menu script entry (#993)
sebastienlagarde Jun 19, 2020
7c88308
Update HDRenderPipeline.cs (#994)
sebastienlagarde Jun 19, 2020
5f17736
Merge branch 'master' into HDRP/staging
sebastienlagarde Jun 19, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -199,10 +199,10 @@ public void OnGUI()

// Even if the asset is not dirty, the list of component may have been changed by another inspector.
// In this case, only the hash will tell us that we need to refresh.
if (asset.isDirty || asset.GetHashCode() != m_CurrentHashCode)
if (asset.isDirty || asset.GetComponentListHashCode() != m_CurrentHashCode)
{
RefreshEditors();
m_CurrentHashCode = asset.GetHashCode();
m_CurrentHashCode = asset.GetComponentListHashCode();
asset.isDirty = false;
}

Expand Down
13 changes: 13 additions & 0 deletions com.unity.render-pipelines.core/Runtime/Volume/VolumeProfile.cs
Original file line number Diff line number Diff line change
Expand Up @@ -297,5 +297,18 @@ public override int GetHashCode()
return hash;
}
}

internal int GetComponentListHashCode()
{
unchecked
{
int hash = 17;

for (int i = 0; i < components.Count; i++)
hash = hash * 23 + components[i].GetType().GetHashCode();

return hash;
}
}
}
}
2 changes: 2 additions & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed warning in HDAdditionalLightData OnValidate (cases 1250864, 1244578)
- Fixed a bug related to denoising ray traced reflections.
- Fixed nullref in the layered lit material inspector.
- Fixed an issue where manipulating the color wheels in a volume component would reset the cursor every time.
- Fixed an issue where static sky lighting would not be updated for a new scene until it's reloaded at least once.

### Changed
- Improve MIP selection for decals on Transparents
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ Please note that if a version control system that requires check out operations
In case the above process fails and a material is not working as expected when upgrading HDRP version, it is suggested to run the upgrade process manually. To do so, you can either:

- Open the [Render Pipeline Wizard](Render-Pipeline-Wizard.html) and under the **Project Migration Quick-links** click on the Upgrade HDRP Materials to Latest Version button. Or:
- Select **Edit > Render Pipelines > Upgrade HDRP Materials to Latest Version**
- Select **Edit > Render Pipelines > HD Render Pipeline > Upgrade from Previous Version > Upgrade HDRP Materials to Latest Version**
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ Note that every **Fix** will be deactivated if your Hardware or OS do not suppor

## Project Migration Quick-links

When upgrading a project from the built-in render pipeline to HDRP, you need to do upgrade your Lights and your Materials. Use the following utility functions to help with the upgrade process:
When upgrading a project from the built-in render pipeline to HDRP, you need to do upgrade your Materials. Use the following utility functions to help with the upgrade process:

- **Upgrade Project Materials to High Definition Materials**: Upgrades every Material in your Unity Project to HDRP Materials.
- **Upgrade Selected Materials to High Definition Materials**: Upgrades every Material currently selected to HDRP Materials.
- **Multiply Unity Builtin Directional Light Intensity to match High Definition**: Multiply intensity of each Directional Light in the current Scene to match HDRP compatible intensity values. Caution: This script should be executed only once.

The lighting will not match as HDRP use a different attenuation function than built-in and use correct math to handle lighting model. There is no function that can convert the look. Thus the lighting will require to be redone.
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ The shader function `SampleShadow_PCSS` now requires you to pass in an additiona

From Unity 2020.2, due to the change of shadow map, the enum HDShadowFilteringQuality have been moved to HDShadowManager.cs and the variables ShaderConfig.s_DeferredShadowFiltering as well as the option ShaderOptions.DeferredShadowFiltering have been removed from the code as they have no impact anymore.

From Unity 2020.2, a new option is available name ColoredShadow. It allow to control if the shadow will be chromatic or monochrome. ColoredShadow have a performance cost. ColoredShadow are the default and currently only work with Raytrace shadow.
From Unity 2020.2, a new option is available named ColoredShadow. It allows you to control whether a shadow is chromatic or monochrome. ColoredShadow is enabled by default and currently only works with [Ray-traced shadows](Ray-Traced-Shadows.md). Note that colored shadows are more resource-intensive to process than standard shadows.

From Unity 2020.2, the Raytracing option and equivalent generated shader macro SHADEROPTIONS_RAYTRACING have been removed. It is not longer require to edit shader config file to use Raytracing features of HDRP.

## Shader code

Expand Down Expand Up @@ -73,8 +75,9 @@ BSDFData bsdfData = ConvertSurfaceDataToBSDFData(posInput.positionSS, surfaceDat
PreLightData preLightData = GetPreLightData(V, posInput, bsdfData);
```

From Unity 2020.2, HDRP includes a new rectangular area shadow evaluation function, EvaluateShadow_RectArea. The GetAreaLightAttenuation() function has been renamed to GetRectAreaShadowAttenuation(). Also the type DirectionalShadowType have been renamed SHADOW_TYPE.

From Unity 2020.2, a new rectangular area shadow have been introduce EvaluateShadow_RectArea and the function GetAreaLightAttenuation() have been rename to GetRectAreaShadowAttenuation(). Also the type DirectionalShadowType have been renamed SHADOW_TYPE.
From Unity 2020.2, the macro ENABLE_RAYTRACING, SHADEROPTIONS_RAYTRACING, and RAYTRACING_ENABLED have been removed. A new multicompile is introduce for forward pass: SCREEN_SPACE_SHADOWS_OFF SCREEN_SPACE_SHADOWS_ON. This allow to enable raytracing effect without requiring edition of shader config file.

## Custom pass API

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public override void OnInspectorGUI()

PropertyField(m_LutContribution, EditorGUIUtility.TrTextContent("Contribution"));

EditorGUILayout.HelpBox("Use \"Edit > Render Pipeline > Render Selected Camera to Log EXR\" to export a log-encoded frame for external grading.", MessageType.Info);
EditorGUILayout.HelpBox("Use \"Edit > Render Pipeline > HD Render Pipeline > Render Selected Camera to Log EXR\" to export a log-encoded frame for external grading.", MessageType.Info);
}
}

Expand All @@ -142,7 +142,7 @@ void CheckCurveRT(int width, int height)

sealed class ExrExportMenu
{
[MenuItem("Edit/Render Pipeline/Render Selected Camera to Log EXR %#&e", priority = CoreUtils.editMenuPriority3)]
[MenuItem("Edit/Render Pipeline/HD Render Pipeline/Render Selected Camera to Log EXR %#&e")]
static void Export()
{
var camera = Selection.activeGameObject?.GetComponent<Camera>();
Expand Down
Loading