Fixes related to planar reflection probes. #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panaman67
reviewed
Jun 16, 2020
| @@ -635,7 +635,7 @@ internal static void ImportAssetAt(HDProbe probe, string file) | |||
| importer.sRGBTexture = false; | |||
| importer.filterMode = FilterMode.Bilinear; | |||
| importer.mipmapEnabled = false; | |||
| importer.textureCompression = hd.currentPlatformRenderPipelineSettings.lightLoopSettings.planarReflectionCacheCompressed | |||
| importer.textureCompression = false | |||
There was a problem hiding this comment.
Could just set to uncompressed right?
There was a problem hiding this comment.
woops didn't see the part of the lines after, my bad
anisunity
force-pushed
the
HDRP/PlanarProbeFormat
branch
from
ac5de55 to
003c174
Compare
sebastienlagarde
approved these changes
Jun 21, 2020
|
Please @JordanL8 keep reviewing the documentation, thanks :) |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested while changing the color buffer format on the HDRP asset
Did not run the test on yamato, will probably require a screenshot update due to minor compression issues