Skip to content

[2022] Reference image updated for Foundation 050 and VFX 103 #6718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

ellioman
Copy link
Contributor

@ellioman ellioman commented Jan 12, 2022

Purpose of this PR

050_Shader_Graphs_deferred + _RenderPass

In #6693 and #6696 I've been updating reference images that were missed in the original PR.
We just fixed a breaking failure in two of our CI jobs so I was able to see those need the same update.

103_LitDeferred

In #6064 I fixed a bug with Specular Materials. In that PR I did update some VFX jobs but missed DX11 Standalone.
This PR updates those.

@ellioman ellioman requested review from a team as code owners January 12, 2022 09:28
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

VFX
/jobDefinition/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@ellioman ellioman merged commit 4b126f3 into master Jan 12, 2022
@ellioman ellioman deleted the universal/050-reference-images-update branch January 12, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants