Skip to content

[2022.2] Updating reference images for 050 Shader Graphs Deferred & Deferred RenderPass #6693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2022

Conversation

ellioman
Copy link
Contributor

@ellioman ellioman commented Jan 7, 2022

Purpose of this PR

When #5762 landed it only updated reference images for

  • 050_Shader_Graphs
  • 050_Shader_Graphs_Override

But missed updating

  • 050_Shader_Graphs_deferred
  • 050_Shader_Graphs_deferred_RenderPass

This PR fixes that and 7 CI jobs affected by that.

Testing status

  • Tested locally in Editor on OSX 11.6 & Unity 2022.2.a1
  • Ran relevant Yamato jobs

@ellioman ellioman requested review from a team as code owners January 7, 2022 13:02
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@ellioman
Copy link
Contributor Author

ellioman commented Jan 7, 2022

The CI Failures are unrelated to this PR.
This PR is successful at removing the failures with the 050 deferred scenes. I'm therefore merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants