Updated XR mirrorview logic #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabien-unity
approved these changes
May 28, 2020
sebastienlagarde
approved these changes
Jun 6, 2020
sebastienlagarde
pushed a commit
that referenced
this pull request
Jun 6, 2020
sebastienlagarde
added a commit
that referenced
this pull request
Jun 12, 2020
* Handling 3dsMax's Simplified Physical Material import. (#569) * [Skip CI] Virtual Texturing cache settings (#536) * Hdrp/docs/volumetric lighting format fix (#628) * Updated volumetric lighting and subsurface scattering docs * Update Override-Diffusion-Profile.md * Adds mention of fidelityfx-cas as requested by AMD (#629) * * Updated XR mirrorview logic to use `TryGetAdditionalCameraDataOrDefault`. (#641) * Update Light-Component.md (#682) * Update HDRP-Camera.md (#706) * Revert "[Skip CI] Virtual Texturing cache settings (#536)" This reverts commit 9794586. Co-authored-by: Thomasch-unity3d <30902625+Thomasch-unity3d@users.noreply.github.com> Co-authored-by: NicoLeyman <49522355+NicoLeyman@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: thomas-zeng <49886741+thomas-zeng@users.noreply.github.com>
sebastienlagarde
pushed a commit
that referenced
this pull request
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Updated xr mirror view to use TryGetAdditionalCameraDataOrDefault.
XRSystem is using TryGetAdditionalCameraDataOrDefault already.
This change improves XR consistency in HDRP.
Testing status
Manual Tests
Automated Tests
Links
Yamato: (Select your branch) https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics
Comments to reviewers