Skip to content

[Skip CI] Virtual Texturing cache settings #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 4, 2020
Merged

[Skip CI] Virtual Texturing cache settings #536

merged 11 commits into from
Jun 4, 2020

Conversation

NicoLeyman
Copy link
Contributor

@NicoLeyman NicoLeyman commented May 18, 2020 •
edited
Loading

This PR is dependant on a trunk PR that changes some VT settings API needed by this PR:

https://ono.unity3d.com/unity/unity/pull-request/106456/_/graphics/virtualtexturing/cache-recreation

Purpose of this PR

This PR adds a new Virtual Texturing section to the HDRP asset.
From this section the sizes of the caches used by the Streaming Virtual Texturing system can be configured.

Testing status

Manual Tests

Manual verification of settings being passed to the VT system correctly, that the settings are applied whenever HDRP re-initializes and that the settings can be changed at runtime.
QA pass will follow in the next few days.

Automated Tests

No new automated tests, didn't seem needed for what is mostly UI code and integration into the serialized HDRP asset.

@NicoLeyman NicoLeyman requested a review from a team as a code owner May 18, 2020 14:54
@NicoLeyman NicoLeyman changed the title Virtual Texturing cache settings [Skip CI] Virtual Texturing cache settings May 19, 2020
@hdb-unity hdb-unity self-requested a review May 19, 2020 12:02
@sebastienlagarde
Copy link
Contributor

Looks ok to me appart from one question, added our QA that have test VT for validation.

TomasKiniulis
TomasKiniulis approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@TomasKiniulis TomasKiniulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tooltip! Did a minor validation that changing CPU Cache Size and GPU Cache Size settings works accordingly in Standalone builds. Settings are correctly grayed out now when VT is disabled in Player Settings

@hdb-unity hdb-unity removed their request for review May 26, 2020 11:07
marctem
marctem suggested changes May 27, 2020
View reviewed changes
Copy link
Contributor

@marctem marctem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the SG file that's from another PR and HD can merge without our input. =)

@NicoLeyman NicoLeyman requested a review from marctem June 2, 2020 10:09
GraphineCharles
GraphineCharles reviewed Jun 2, 2020
View reviewed changes
@sebastienlagarde sebastienlagarde merged commit 33419f4 into master Jun 4, 2020
@sebastienlagarde sebastienlagarde deleted the virtualtexturing-settings branch June 4, 2020 20:20
sebastienlagarde pushed a commit that referenced this pull request Jun 6, 2020
@NicoLeyman @sebastienlagarde
[Skip CI] Virtual Texturing cache settings (#536)
9794586
@sebastienlagarde sebastienlagarde mentioned this pull request Jun 6, 2020
Merged
6 tasks
@NicoLeyman NicoLeyman mentioned this pull request Jun 9, 2020
Merged
sebastienlagarde added a commit that referenced this pull request Jun 11, 2020
@sebastienlagarde
Revert "[Skip CI] Virtual Texturing cache settings (#536)"
48f80ab 
This reverts commit 9794586.
sebastienlagarde added a commit that referenced this pull request Jun 12, 2020
@sebastienlagarde @Thomasch-unity3d
@NicoLeyman @JordanL8 @thomas-zeng
[9.x.x] Misc doc and FBX backport [Need C++ PR] (#751)
865e56d 
* Handling 3dsMax's Simplified Physical Material import. (#569)

* [Skip CI] Virtual Texturing cache settings (#536)

* Hdrp/docs/volumetric lighting format fix (#628)

* Updated volumetric lighting and subsurface scattering docs

* Update Override-Diffusion-Profile.md

* Adds mention of fidelityfx-cas as requested by AMD (#629)

* * Updated XR mirrorview logic to use `TryGetAdditionalCameraDataOrDefault`. (#641)

* Update Light-Component.md (#682)

* Update HDRP-Camera.md (#706)

* Revert "[Skip CI] Virtual Texturing cache settings (#536)"

This reverts commit 9794586.

Co-authored-by: Thomasch-unity3d <30902625+Thomasch-unity3d@users.noreply.github.com>
Co-authored-by: NicoLeyman <49522355+NicoLeyman@users.noreply.github.com>
Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
Co-authored-by: thomas-zeng <49886741+thomas-zeng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GraphineCharles GraphineCharles GraphineCharles left review comments

@sebastienlagarde sebastienlagarde sebastienlagarde left review comments

@TomasKiniulis TomasKiniulis TomasKiniulis approved these changes

@marctem marctem Awaiting requested review from marctem

Assignees
No one assigned
Labels
backported-9.x HDRP Shader Graph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NicoLeyman @sebastienlagarde @GraphineCharles @marctem @TomasKiniulis @GraphineNicolas