[2022.1] Universal: Fixing 146 MSAA test scene. #6065
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a0c849e.
# Conflicts: # TestProjects/UniversalGraphicsTest_PostPro/Assets/ReferenceImages/Linear/LinuxPlayer/Vulkan/None/146_MSAA_RenderToBackbuffer.png
# Conflicts: # TestProjects/UniversalGraphicsTest_PostPro/Assets/ReferenceImages/Linear/LinuxPlayer/Vulkan/None/146_MSAA_RenderToBackbuffer.png
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. URP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
|
It appears that you made a non-draft PR! |
phi-lira
approved these changes
Oct 20, 2021
phi-lira
added a commit
that referenced
this pull request
Oct 20, 2021
commit 6d8b669 Merge: 72deede 5b53dd5 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Tue Oct 19 13:56:40 2021 +0200 Merge branch 'master' into universal/fix-msaa-test # Conflicts: # TestProjects/UniversalGraphicsTest_PostPro/Assets/ReferenceImages/Linear/LinuxPlayer/Vulkan/None/146_MSAA_RenderToBackbuffer.png commit 72deede Merge: 289157a 883bd1c Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Tue Sep 21 09:56:18 2021 +0200 Merge branch 'master' into universal/fix-msaa-test commit 289157a Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 11:07:07 2021 +0200 Updating Reference Images for DX11 and DX12 commit a3ac932 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 10:34:32 2021 +0200 Lowering the threshold to 0.001 commit 861336e Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 10:33:34 2021 +0200 Increasing the test threshold from 0 to 0.0025 commit 5d16930 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 10:09:36 2021 +0200 Reverting a change in QualitySettings commit 1ccfb01 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 09:43:02 2021 +0200 Materials commit ba0de50 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 09:42:08 2021 +0200 Reverting a change in GraphicsSettings and QualitySettings commit 9dced83 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 08:26:18 2021 +0200 Minor cleanup of RP Assets. commit f0c5d56 Merge: 83fa04a f0467f4 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 08:11:44 2021 +0200 Merge branch 'master' into universal/fix-msaa-test # Conflicts: # TestProjects/UniversalGraphicsTest_PostPro/Assets/ReferenceImages/Linear/LinuxPlayer/Vulkan/None/146_MSAA_RenderToBackbuffer.png commit 83fa04a Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Fri Feb 19 13:24:15 2021 +0100 Fixing MSAA test scene commit f2c3b10 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Fri Feb 19 13:08:27 2021 +0100 Revert "Fixing 146 MSAA test." This reverts commit a0c849e. commit a0c849e Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Fri Feb 19 13:04:51 2021 +0100 Fixing 146 MSAA test.
Merged
phi-lira
added a commit
that referenced
this pull request
Oct 22, 2021
commit 6d8b669 Merge: 72deede 5b53dd5 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Tue Oct 19 13:56:40 2021 +0200 Merge branch 'master' into universal/fix-msaa-test # Conflicts: # TestProjects/UniversalGraphicsTest_PostPro/Assets/ReferenceImages/Linear/LinuxPlayer/Vulkan/None/146_MSAA_RenderToBackbuffer.png commit 72deede Merge: 289157a 883bd1c Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Tue Sep 21 09:56:18 2021 +0200 Merge branch 'master' into universal/fix-msaa-test commit 289157a Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 11:07:07 2021 +0200 Updating Reference Images for DX11 and DX12 commit a3ac932 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 10:34:32 2021 +0200 Lowering the threshold to 0.001 commit 861336e Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 10:33:34 2021 +0200 Increasing the test threshold from 0 to 0.0025 commit 5d16930 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 10:09:36 2021 +0200 Reverting a change in QualitySettings commit 1ccfb01 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 09:43:02 2021 +0200 Materials commit ba0de50 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 09:42:08 2021 +0200 Reverting a change in GraphicsSettings and QualitySettings commit 9dced83 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 08:26:18 2021 +0200 Minor cleanup of RP Assets. commit f0c5d56 Merge: 83fa04a f0467f4 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Thu Sep 16 08:11:44 2021 +0200 Merge branch 'master' into universal/fix-msaa-test # Conflicts: # TestProjects/UniversalGraphicsTest_PostPro/Assets/ReferenceImages/Linear/LinuxPlayer/Vulkan/None/146_MSAA_RenderToBackbuffer.png commit 83fa04a Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Fri Feb 19 13:24:15 2021 +0100 Fixing MSAA test scene commit f2c3b10 Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Fri Feb 19 13:08:27 2021 +0100 Revert "Fixing 146 MSAA test." This reverts commit a0c849e. commit a0c849e Author: Elvar Örn Unnþórsson <ellioman@ellioman.com> Date: Fri Feb 19 13:04:51 2021 +0100 Fixing 146 MSAA test.
|
Merged onto staging branch. Staging branch landed onto master on #6085 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Second attempt at landing this PR. First attempt was #3570
Previously when I modified this test scene in #2802, I broke the backbuffer part of the test.
This PR fixes that to make sure we are testing BackBuffer MSAA properly.