Skip to content

fix for freeze during render settings converter #6017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 12, 2021
Merged

fix for freeze during render settings converter #6017

merged 5 commits into from
Nov 12, 2021

Conversation

martint-unity
Copy link
Contributor

Purpose of this PR

Backport of this PR
#6015

Testing status

Manual testing of the converter

@martint-unity martint-unity requested review from a team as code owners October 14, 2021 09:15
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

simon-engelbrecht-soerensen
simon-engelbrecht-soerensen approved these changes Oct 18, 2021
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@martint-unity martint-unity merged commit e647fb3 into 2021.2/staging Nov 12, 2021
@martint-unity martint-unity deleted the 2021.2/universal/backport/fix-for-freeze-in-renderpipeline-converter branch November 12, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellioman ellioman ellioman approved these changes

@simon-engelbrecht-soerensen simon-engelbrecht-soerensen simon-engelbrecht-soerensen approved these changes

Assignees
No one assigned
Labels
universal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martint-unity @ellioman @simon-engelbrecht-soerensen