fix for freeze in renderpipeline converter #6015
Conversation
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. URP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
|
It appears that you made a non-draft PR! |
There was a problem hiding this comment.
Well, I don't get why this solve your issue. But it seams to help.
@bastienunity can I have your feedback on this change? AFAIK it should speed up having the assetdatabase be in asset editing mode in order to batch change written on disc. It seams in some case it can cause issue.
|
@RSlysz StartAssetEditing and StopAssetEditing should be used to group large asset operations together. Looking at what this method is doing, it modifies assets in memory and then calls for SaveAssets, which already batches all the writing to disk together, so it should be fine to not use it in that case. |
| @@ -680,7 +679,6 @@ void Convert(ClickEvent evt) | |||
| } | |||
| m_CoreConvertersList[index].OnPostRun(); | |||
| AssetDatabase.SaveAssets(); | |||
There was a problem hiding this comment.
Quick question, why is SaveAssets done in the foreach loop and not just one time after every possible conversion is done?
There was a problem hiding this comment.
I think we added it here because then we know that things are saved between different converters.
…erpipeline-converter
Fixed changelog merge issue
…eze-in-renderpipeline-converter
phi-lira
deleted the
universal/converter/fix-for-freeze-in-renderpipeline-converter
branch
* fix for freeze in renderpipeline converter * updated changelog * Update CHANGELOG.md Fixed changelog merge issue Co-authored-by: Felipe Lira <felipedrl@gmail.com>
Purpose of this PR
Fix for this FB Case
https://fogbugz.unity3d.com/f/cases/1353885/
When converting using renderer settings converter it froze if there were more than one setting to convert. This fixes that.
Testing status
Manual tested the bug retro steps from the fogbugz case.