-
Notifications
You must be signed in to change notification settings - Fork 840
[VFX] Fix compilation error when using cubemap arrays #5582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…orm supporting it)
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. VFX Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Developer-tested, not much for QA to do beside re-run the same tests.
Auto-approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workaround looks good to me, we should double check the status of this Yamato job : https://unity-ci.cds.internal.unity3d.com/job/8630091 (VFX_HDRP in edit mode)
Update
Definitely not related to your change, I'm looking for the root cause ⏳ |
…orm supporting it) (#5582)
…orm supporting it) (#5582)
* Fix sanitize of exposed Camera parameters * Fix SDF Baker on PS4/5 failing due to explicit binding * Fixed NRE when starting play mode (#279) * Fixed NRE when starting play mode * Save auto-attach lock state and attached VFX in the editor prefs to avoid loosing them when going in play mode * Better restore attached VFX when leaving play mode (even if it has been removed during play) * Fix compil error when cubemap array is used in compute (even on platform supporting it) (#5582) * Update HDRP assets * Fix failing test Co-authored-by: Gabriel de la Cruz <gabriel.delacruz@unity3d.com> Co-authored-by: Ludovic Theobald <ludovic.theobald@unity3d.com> Co-authored-by: Julien Amsellem <julien.amsellem@unity3d.com>
* Fix sanitize of exposed Camera parameters * Fix SDF Baker on PS4/5 failing due to explicit binding * Fixed NRE when starting play mode (#279) * Fixed NRE when starting play mode * Save auto-attach lock state and attached VFX in the editor prefs to avoid loosing them when going in play mode * Better restore attached VFX when leaving play mode (even if it has been removed during play) * Fix compil error when cubemap array is used in compute (even on platform supporting it) (#5582) * Update HDRP assets * Fix failing test * Fix failing test * Revert "Fix failing test" This reverts commit c6fe054. * [VFX] Importer and compilation various fixes #5371 Co-authored-by: Gabriel de la Cruz <gabriel.delacruz@unity3d.com> Co-authored-by: Ludovic Theobald <ludovic.theobald@unity3d.com> Co-authored-by: Julien Amsellem <julien.amsellem@unity3d.com>
…orm supporting it) (#5582)
Purpose of this PR
This fixes an issue introduced by #5149
Edit mode tests are currently failing on master because of that.
Typically using cubemap array in a graph (in a compute pass) currently ends up with a compile error, even on platforms supporting it.
This is fixed by this PR.
This is a temp workaround, I created a fogbugz as well for Shader System team to fix it properly https://fogbugz.unity3d.com/f/cases/1364139/
Testing status
Tested locally that all VFX tests pass
Comments to reviewers
Notes for the reviewers you have assigned.