Skip to content

[VFX] Fix compilation error when using cubemap arrays #5582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

julienf-unity
Copy link
Contributor

@julienf-unity julienf-unity commented Sep 9, 2021

Purpose of this PR

This fixes an issue introduced by #5149
Edit mode tests are currently failing on master because of that.

Typically using cubemap array in a graph (in a compute pass) currently ends up with a compile error, even on platforms supporting it.
This is fixed by this PR.

This is a temp workaround, I created a fogbugz as well for Shader System team to fix it properly https://fogbugz.unity3d.com/f/cases/1364139/


Testing status

Tested locally that all VFX tests pass


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

github-actions bot commented Sep 9, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@julienf-unity julienf-unity requested a review from a team September 9, 2021 09:59
@github-actions github-actions bot added the vfx label Sep 9, 2021
@julienf-unity julienf-unity mentioned this pull request Sep 9, 2021
Copy link
Contributor

@VladNeykov VladNeykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Developer-tested, not much for QA to do beside re-run the same tests.
Auto-approving.

Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workaround looks good to me, we should double check the status of this Yamato job : https://unity-ci.cds.internal.unity3d.com/job/8630091 (VFX_HDRP in edit mode)

@PaulDemeulenaere
Copy link
Contributor

Update
We got an issue in HDRP Edit Mode:

[12:48:46.351 Information] [496/1143] TestFinish
	name: UnityEditor.VFX.Test.VisualEffectTest.CreateComponent_Modify_Value_Doesnt_Reset(False,True)
	result: FAILED
	message: Unhandled log message: '[Exception] ArgumentException: Getting control 9's position in a group with only 9
[12:48:46.355 Information]  controls when doing repaint

Definitely not related to your change, I'm looking for the root cause ⏳
Feel free to merge.

@julienf-unity julienf-unity merged commit e28ed8a into master Sep 9, 2021
@julienf-unity julienf-unity deleted the vfx/fix/cubemaparray_support branch September 9, 2021 15:02
julienf-unity added a commit that referenced this pull request Sep 9, 2021
julienf-unity added a commit that referenced this pull request Sep 9, 2021
* [VFX] Mobile fixes (#5149)

* Fix compil error when cubemap array is used in compute (even on platform supporting it) (#5582)
julienf-unity added a commit that referenced this pull request Sep 17, 2021
julienf-unity added a commit that referenced this pull request Sep 19, 2021
* Fix sanitize of exposed Camera parameters

* Fix SDF Baker on PS4/5 failing due to explicit binding

* Fixed NRE when starting play mode (#279)

* Fixed NRE when starting play mode

* Save auto-attach lock state and attached VFX in the editor prefs to avoid loosing them when going in play mode

* Better restore attached VFX when leaving play mode (even if it has been removed during play)

* Fix compil error when cubemap array is used in compute (even on platform supporting it) (#5582)

* Update HDRP assets

* Fix failing test

Co-authored-by: Gabriel de la Cruz <gabriel.delacruz@unity3d.com>
Co-authored-by: Ludovic Theobald <ludovic.theobald@unity3d.com>
Co-authored-by: Julien Amsellem <julien.amsellem@unity3d.com>
julienf-unity added a commit that referenced this pull request Sep 20, 2021
* Fix sanitize of exposed Camera parameters

* Fix SDF Baker on PS4/5 failing due to explicit binding

* Fixed NRE when starting play mode (#279)

* Fixed NRE when starting play mode

* Save auto-attach lock state and attached VFX in the editor prefs to avoid loosing them when going in play mode

* Better restore attached VFX when leaving play mode (even if it has been removed during play)

* Fix compil error when cubemap array is used in compute (even on platform supporting it) (#5582)

* Update HDRP assets

* Fix failing test

* Fix failing test

* Revert "Fix failing test"

This reverts commit c6fe054.

* [VFX] Importer and compilation various fixes #5371

Co-authored-by: Gabriel de la Cruz <gabriel.delacruz@unity3d.com>
Co-authored-by: Ludovic Theobald <ludovic.theobald@unity3d.com>
Co-authored-by: Julien Amsellem <julien.amsellem@unity3d.com>
julienf-unity added a commit that referenced this pull request Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants