Skip to content

[VFX] Backports 2021.2 #5709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 19, 2021
Merged

[VFX] Backports 2021.2 #5709

merged 8 commits into from
Sep 19, 2021

Conversation

julienf-unity
Copy link
Contributor

Purpose of this PR

Fixes:

  • Exposed Camera property fails to upgrade and is converted to a float type Case 1357685
  • Fix SDF Baker fail on PS4 & PS5 Case 1351595
  • Fix NRE with attachment workflow
  • Fix cubemap array support

Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

gabrieldelacruz and others added 5 commits September 17, 2021 11:43
* Fixed NRE when starting play mode

* Save auto-attach lock state and attached VFX in the editor prefs to avoid loosing them when going in play mode

* Better restore attached VFX when leaving play mode (even if it has been removed during play)
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I didn't notice unexpected changes 🟢

@julienf-unity julienf-unity merged commit d59dfd0 into 2021.2/staging Sep 19, 2021
@julienf-unity julienf-unity deleted the 2021.2/vfx/staging branch September 19, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants