-
Notifications
You must be signed in to change notification settings - Fork 839
[HDRP][Path Tracing] Directional light color now affected by physical sky #5567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
131 commits
Select commit
Hold shift + click to select a range
5945333
[HDRP] Fix AxF debug output in certain configurations (#4641)
pmavridis 64a6c13
Fix SSR accumulation white flash (#4648)
FrancescoC-unity f49b710
Display Info Box when MSAA + ray tracing is onr (#4627)
FrancescoC-unity 05cc16a
Fix distortion when resizing the window in player builds with the Gra…
pmavridis 2325e3f
Add support for the camera bridge in the graphics compositor (#4599)
pmavridis c09379f
Merge branch 'master' into hd/bugfix
sebastienlagarde b5962c9
Fix Jittered Project Matrix Infinite Far Clip Plane (#4638)
johnpars 77b6b7f
Fixed a memory leak related to not disposing of the RTAS at the end H…
anisunity bf941a9
Fix custom pass utils Blur + Copy overdraw. (#4623)
alelievr 806dfbe
Fix draw procedural invalid pass idx 1 on first template load (#4632)
FrancescoC-unity 88779ea
Changed light reset to preserve type (#4624)
adrien-de-tocqueville 30fffd5
Revert "Add support for the camera bridge in the graphics compositor …
sebastienlagarde aabbb4b
AxF carpaint: Fix a compilation issue on Vulkan until the cpp HLSLcc …
slunity dfdb311
Revert "Revert "Add support for the camera bridge in the graphics com…
sebastienlagarde 891fda0
revert: Fix distortion when resizing the window in player builds with…
sebastienlagarde 7b17e06
Merge branch 'master' into hd/bugfix
sebastienlagarde 32df1bf
Merge branch 'master' into hd/bugfix
sebastienlagarde 8fd1108
Fixed the ray traced sub subsurface scattering debug mode not display…
anisunity 0032b9c
Fix for discrepancies in saturation and intensity between screen spac…
FrancescoC-unity 41716f0
Fix a Divide-by-Zero Warning for some Anisotropic Models (Fabric, Lit…
johnpars 333c800
[HDRP] Fix VfX lit particle AOV output color space (#4646)
pmavridis 809316c
[HDRP][Path Tracing] Fixed transparent unlit (#4605)
eturquin 7b1ad29
Merge branch 'master' into hd/bugfix
sebastienlagarde 08a578d
Fix distortion with MSAA (#4711)
sebastienlagarde 3c418c0
Fix contact shadow debug views (#4720)
FrancescoC-unity 352f65d
Update Decal-Projector.md (#4695)
adrien-de-tocqueville acc5073
[HDRP] Fixed nullref when deleting the texture asset assigned in a lo…
alelievr fd54a00
Merge branch 'master' into hd/bugfix
sebastienlagarde 1672dc6
Fix decal layer enum (#4753)
sebastienlagarde c40c5c5
Fix typo
sebastienlagarde b443d6e
Fixed reflection probes being injected into the ray tracing light clu…
anisunity bc1d498
Ignore hybrid duplicated reflection probes during light baking (#4663)
adrien-de-tocqueville 99bc6fd
Fix double sided option moving when toggling it in the material UI (#…
alelievr 4a184af
Merge branch 'master' into hd/bugfix
sebastienlagarde d2368ba
Fix formatting
sebastienlagarde e5521be
Merge branch 'master' into hd/bugfix
sebastienlagarde 97a953e
Fix volumetric fog in planar reflections (#4736)
FrancescoC-unity 419850b
Fix motion blur compute dispatch size (#4737)
adrien-de-tocqueville fc7efde
- Updated the recursive rendering documentation (case 1338639). (#4759)
anisunity ca93d88
Fix issue with OnDemand directional shadow map being corrupted when r…
FrancescoC-unity c674c41
Fix cropping issue with the compositor camera bridge (#4802)
pmavridis e47a172
Fix for unused resources in depth of field (#4796)
Adrian1066 131d1cd
Merge branch 'master' into hd/bugfix
sebastienlagarde 666d37f
Merge branch 'master' into hd/bugfix
sebastienlagarde 61518ea
Removing the word Radii from exposure settings (#4854)
FrancescoC-unity 85ebbc2
[HDRP][Path Tracing] Support for shadow mattes (#4745)
eturquin ad127f5
Revert "[HDRP][Path Tracing] Support for shadow mattes (#4745)"
sebastienlagarde 2c08712
Fixed the transparent cutoff not working properly in semi-transparent…
anisunity 83ddbed
Use non jittered projection in outline pass (#4836)
adrien-de-tocqueville 2d9d391
[HDRP][Path Tracing] Sky settings now properly taken into account whe…
eturquin 30cbb05
Fix Resolution Issues for Physically Based Depth of Field (#4848)
johnpars 5c6b711
Fixed bug introduced by sky-for-recorder support. (#4906)
eturquin 3cb7354
[Fogbugz 1341576] Memory leaks when the player is paused, and the use…
kecho 1ee6c2d
Merge branch 'master' into hd/bugfix
sebastienlagarde 7615d7b
[HDRP] Fixed shadergraph double save (#4916)
alelievr be0e48e
Merge master
sebastienlagarde 30135ea
Write 0 instead of micro sized motion vectors + fix extremely fast ve…
FrancescoC-unity df51161
[HDRP] Fix material upgrader (#4821)
alelievr 2bc152b
[HDRP] Fix custom pass volume not executed in scene view (#4860)
alelievr bac78c1
Merge branch 'master' of https://github.com/Unity-Technologies/Graphi…
JulienIgnace-Unity b0442c6
Fix reflection probe tootltip (#4890)
adrien-de-tocqueville 51af23d
Updated the Physically Based Sky documentation for baked lights (#4891)
adrien-de-tocqueville 7f5b564
Fixed remapping of depth pyramid debug (#4893)
JulienIgnace-Unity 24b3ea9
Fix wobble-like (or tearing-like) SSAO issues when temporal reproject…
FrancescoC-unity 3f2772b
Fix Asymmetric Projection Matrices and Fog / Pathtracing (#4926)
johnpars 4d1c13c
Merge branch 'master' into hd/bugfix
sebastienlagarde 0bc3a8b
Merge master
sebastienlagarde 0833363
Revert: Fix wobble-like (or tearing-like) SSAO issues when temporal r…
sebastienlagarde b307e87
Merge branch 'master' into hd/bugfix
sebastienlagarde 2f4a545
Fix GBuffer depth debug mode (#5054)
adrien-de-tocqueville 1772558
Fixed Volume Gizmo size when rescaling parent GameObject (#4915)
adrien-de-tocqueville d88d1eb
Fix Vertex Color Mode documentation (#4976)
adrien-de-tocqueville 6692daf
Merge master
sebastienlagarde 8ef3637
Fix wobble-like (or tearing-like) SSAO issues when temporal reproject…
FrancescoC-unity 5dd669e
Fix formatting in NestedOverrideCameraRendering
sebastienlagarde a299cb8
[HDRP] Fix white flash with SSR when resetting camera history (#5089)
pmavridis 8c39e99
[Fobguz # 1348357] VFX Particle templates missing stencil flags (#5080)
kecho c5dd9c6
Merge branch 'master' into hd/bugfix
sebastienlagarde df294f7
Fix object disappearing from lookdev (#5063)
alelievr ce1f22a
merge master
sebastienlagarde ae9e7a6
[HDRP] Fix render object after taa jittering (#5088)
alelievr 883197e
Fix GC alloc in hd/bugfix branch (#5134)
alelievr eeb2ce5
Fix refraction tile artifacts near reflection probe edges (#4727)
FrancescoC-unity feb034c
Fix camera rotation uncontrollable with low framerate (#5076)
alelievr f4b940e
Clearing out render targets and randmo write targets on pipeline dest…
kecho 455ebc2
Fixed a null ref exception when adding a new environment to the libra…
JulienIgnace-Unity f20b3d8
FogBugz#1348462 - Wait for accessing the HDProjectSettings instance a…
alex-vazquez 8722fe0
Fix nullref in volume system after deleting a volume object (#5161)
alelievr 21fdf2e
merge master
sebastienlagarde bc579c7
[HDRP] Fix APV UI loosing focus when changing a param (#5219)
alelievr a9cc22e
Merge branch 'master' into hd/bugfix
sebastienlagarde 3a75e92
Small changes (#5220)
FrancescoC-unity 9bf35af
Fix update order in Graphics Compositor causing jumpy camera updates …
pmavridis bf1b3e0
Prevent material from having infinite intensity (#5132)
adrien-de-tocqueville b6876a7
merge master
sebastienlagarde 1bfc26e
[HDRP] Adding limitations of decal emissive positive contribution to …
remi-chapelain 72d81c0
[HDRP] Fix issue with path tracing when switching between non-persist…
pmavridis 77957b5
removed undesired files
sebastienlagarde bd814d5
Fix log base (#5260)
adrien-de-tocqueville 7e2ffce
[HDRP] Fixed mask value stored by the LayerMaskParameter class (#5250)
eturquin d292c63
[HDRP][DXR] Make vertex color default to 1.0 instead of 0.0 (#5268)
eturquin 556b0b3
Merge branch 'master' into hd/bugfix
sebastienlagarde 87c680e
Fix issue with 0-sized dispatch with extremely low resolutions (#5272)
FrancescoC-unity 3d50437
Merge branch 'master' into hd/bugfix
sebastienlagarde 6057424
merge master
sebastienlagarde b7d7011
[HDRP] Fix incorrect light list indexing when TAA is enabled (#5287)
pmavridis 660c292
merge master
sebastienlagarde 16e98f0
Fix incorrect additiona velocity for alembic (#5304)
sebastienlagarde 452a1ab
Fixed LUT initialization in Wireframe mode (#5156)
adrien-de-tocqueville b306e57
[HDRP] [LightExplorer] Fix missing refreshwhen editing property with …
RSlysz b7ef709
Merge branch 'master' of https://github.com/Unity-Technologies/Graphi…
JulienIgnace-Unity 0f55c10
Changed Ambient Mode to Dynamic by default (#5350)
JulienIgnace-Unity 2320588
Hd/fix framesettings ordering (#5323)
RSlysz 5efb85a
Bugfix 1357311: Fixed old ray tracing material conversion (#5364)
JarkkoUnity cd8bd25
Bugfix 1358480: Fixed missing tooltip for "Tessellation Mode" (#5365)
JarkkoUnity 314d2aa
[HDRP] Fix HD template (particularly visible in path tracing) (#5319)
eturquin d5ff09e
merge master
sebastienlagarde 88819d9
Revert: Changed Ambient Mode to Dynamic by default #5350
sebastienlagarde 31fbb1a
merge master
sebastienlagarde 069186f
Merge master
sebastienlagarde 558b3d6
Fixed a null ref exception when no opaque objects are rendered. (#5463)
JulienIgnace-Unity ab78e9f
Fix slope scale depth bias when depth offset is ON (#5466)
FrancescoC-unity 46bf4f0
[HDRP] Fix spot shadow sampling when using custom spot angle (#5439)
alelievr 5abdf18
Fix darkening in SSR fade (#5472)
FrancescoC-unity 0996bd3
[HDRP] Improve path traced subsurface scattering for transmissive sur…
pmavridis b522d8b
Fix missing context menu for 'Post Anti-Aliasing' in Camera (1357283)…
RSlysz b4cebb2
Force allocate texture if no fallback is available (#5130)
adrien-de-tocqueville 9745a21
Dir light color now affected by physical sky in PT.
eturquin 3cef16d
Updated changelog.
eturquin b61e833
merge master
sebastienlagarde ac1d70b
Merge branch 'master' into hd/pt_physky_dir
sebastienlagarde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sanity check, is this code call for any kind of sky? what's happen with an HDRI sky?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was the same in the original function, I think it comes from the dynamic if() condition right after this (or at least that's what I saw when checking its effect: if the "affect sky" on the light is off, or if there is no physical sky, then the if condition is false).