[HDRP][Path Tracing] Directional light color now affected by physical sky #5567

eturquin · 2021-09-08T13:52:27Z

This addresses: https://fogbugz.unity3d.com/f/cases/1363584/

Before:
In path tracing, when sky model was set to physical, directional light emission color wasn't affected by its direction

Now:
Emission color is affected by direction (warmer colors) at grazing angles, then zero under horizon (as is the case in rasterization).

* Fix AxF debug output in certain configurations. * Update comment

* Fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <f.cifariellociardi@gmail.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…4599)" This reverts commit 2325e3f.

…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…positor (#4599)"" This reverts commit 30fffd5.

… the Graphi

…ing only the RTSSS Data (case 1332904). (#4626) * Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904). * Add test scene Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix slope scale bias being broken when depth offset was enabled * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed shadow sampling artifact when using the spot light shadow option 'custom spot angle' * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…faces (#5485) * Improve subsurface scatering for transmissive surfaces * Add changelog + fix throughput multiplication Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…#5497) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

github-actions · 2021-09-08T13:52:43Z

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

sebastienlagarde · 2021-09-08T16:12:02Z

Please trigger Yamato.
Note to self: redirect PR to master

sebastienlagarde · 2021-09-08T16:13:00Z

...r-pipelines.high-definition/Runtime/RenderPipeline/PathTracing/Shaders/PathTracingLight.hlsl

+#if SHADEROPTIONS_PRECOMPUTED_ATMOSPHERIC_ATTENUATION
+    // Nothing to do here
+#else
+    // Physical sky emission color code, adapted from EvaluateLight_Directional()


Sanity check, is this code call for any kind of sky? what's happen with an HDRI sky?

It was the same in the original function, I think it comes from the dynamic if() condition right after this (or at least that's what I saw when checking its effect: if the "affect sky" on the light is off, or if there is no physical sky, then the if condition is false).

eturquin · 2021-09-09T14:18:15Z

Please trigger Yamato.

DXR tests broken atm, we should merge #5551 before this one, so that we get clean tests again. It is likely that this new PR will break one test too, will have to be updated after this other merge.

iM0ve

What's tested:

Repro case with physical sky
Verified that using HDRI the sun angle doesnt impact color
As bonus, did a smoke test for all Physical sky properties with Pathtracer

Showcase <3

ETtLcoAswV.mp4

… sky #5567

pmavridis and others added 30 commits May 26, 2021 19:23

[HDRP] Fix AxF debug output in certain configurations (#4641)

5945333

* Fix AxF debug output in certain configurations. * Update comment

Fix SSR accumulation white flash (#4648)

64a6c13

* Fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Display Info Box when MSAA + ray tracing is onr (#4627)

f49b710

* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix distortion when resizing the window in player builds with the Gra…

05cc16a

…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Add support for the camera bridge in the graphics compositor (#4599)

2325e3f

Merge branch 'master' into hd/bugfix

c09379f

Fix Jittered Project Matrix Infinite Far Clip Plane (#4638)

b5962c9

* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed a memory leak related to not disposing of the RTAS at the end H…

77b6b7f

…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix custom pass utils Blur + Copy overdraw. (#4623)

bf941a9

* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix draw procedural invalid pass idx 1 on first template load (#4632)

806dfbe

* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <f.cifariellociardi@gmail.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Changed light reset to preserve type (#4624)

88779ea

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Revert "Add support for the camera bridge in the graphics compositor (#…

30fffd5

…4599)" This reverts commit 2325e3f.

AxF carpaint: Fix a compilation issue on Vulkan until the cpp HLSLcc …

aabbb4b

…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Revert "Revert "Add support for the camera bridge in the graphics com…

dfdb311

…positor (#4599)"" This reverts commit 30fffd5.

revert: Fix distortion when resizing the window in player builds with…

891fda0

… the Graphi

Merge branch 'master' into hd/bugfix

7b17e06

Merge branch 'master' into hd/bugfix

32df1bf

Fix for discrepancies in saturation and intensity between screen spac…

0032b9c

…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

Fix a Divide-by-Zero Warning for some Anisotropic Models (Fabric, Lit) (

41716f0

#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP] Fix VfX lit particle AOV output color space (#4646)

333c800

* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP][Path Tracing] Fixed transparent unlit (#4605)

809316c

* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

7b1ad29

Fix distortion with MSAA (#4711)

08a578d

Fix contact shadow debug views (#4720)

3c418c0

* Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Update Decal-Projector.md (#4695)

352f65d

[HDRP] Fixed nullref when deleting the texture asset assigned in a lo…

acc5073

…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

fd54a00

Fix decal layer enum (#4753)

1672dc6

Fix typo

c40c5c5

FrancescoC-unity and others added 7 commits August 31, 2021 14:19

Fix slope scale depth bias when depth offset is ON (#5466)

ab78e9f

* Fix slope scale bias being broken when depth offset was enabled * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP] Fix spot shadow sampling when using custom spot angle (#5439)

46bf4f0

* Fixed shadow sampling artifact when using the spot light shadow option 'custom spot angle' * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix darkening in SSR fade (#5472)

5abdf18

* Fix * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP] Improve path traced subsurface scattering for transmissive sur…

0996bd3

…faces (#5485) * Improve subsurface scatering for transmissive surfaces * Add changelog + fix throughput multiplication Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix missing context menu for 'Post Anti-Aliasing' in Camera (1357283) (…

b522d8b

…#5497) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Force allocate texture if no fallback is available (#5130)

b4cebb2

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Dir light color now affected by physical sky in PT.

9745a21

eturquin added SRP HDRP dxr labels Sep 8, 2021

eturquin requested review from sebastienlagarde and iM0ve September 8, 2021 13:52

Updated changelog.

3cef16d

sebastienlagarde added the needs-backport-2021.2 label Sep 8, 2021

sebastienlagarde reviewed Sep 8, 2021

View reviewed changes

merge master

b61e833

sebastienlagarde changed the base branch from hd/bugfix to master September 12, 2021 20:41

sebastienlagarde marked this pull request as ready for review September 12, 2021 20:42

iM0ve approved these changes Sep 16, 2021

View reviewed changes

Merge branch 'master' into hd/pt_physky_dir

ac1d70b

sebastienlagarde merged commit f43c36f into master Sep 16, 2021

sebastienlagarde deleted the hd/pt_physky_dir branch September 16, 2021 17:32

sebastienlagarde added backported-2021.1 backported-2021.2 and removed needs-backport-2021.2 backported-2021.1 labels Sep 20, 2021

sebastienlagarde pushed a commit that referenced this pull request Sep 20, 2021

[HDRP][Path Tracing] Directional light color now affected by physical…

51849e3

… sky #5567

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[HDRP][Path Tracing] Directional light color now affected by physical sky #5567

[HDRP][Path Tracing] Directional light color now affected by physical sky #5567

Uh oh!

eturquin commented Sep 8, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Sep 8, 2021

Uh oh!

sebastienlagarde commented Sep 8, 2021

Uh oh!

sebastienlagarde Sep 8, 2021

Uh oh!

eturquin Sep 9, 2021

Uh oh!

eturquin commented Sep 9, 2021

Uh oh!

iM0ve left a comment •

edited

Loading

Uh oh!

Uh oh!

[HDRP][Path Tracing] Directional light color now affected by physical sky #5567

[HDRP][Path Tracing] Directional light color now affected by physical sky #5567

Uh oh!

Conversation

eturquin commented Sep 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 8, 2021

Uh oh!

sebastienlagarde commented Sep 8, 2021

Uh oh!

sebastienlagarde Sep 8, 2021

Choose a reason for hiding this comment

Uh oh!

eturquin Sep 9, 2021

Choose a reason for hiding this comment

Uh oh!

eturquin commented Sep 9, 2021

Uh oh!

iM0ve left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eturquin commented Sep 8, 2021 •

edited

Loading

iM0ve left a comment •

edited

Loading