[VFX] Add Vulkan in Extra_VFX_URP #5436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Adding Windows Vulkan among Extra VFX_URP playmode test because the incoming support for new SG integration with URP requires specific code generation for Vulkan & DX12 behaviors.
Testing status
Yamato 🟢
I noticed an issue with the mesh sampling test but I can't reproduce locally
Locally
Yamato
See this fogbugz
Comments to reviewers
VFX_HDRP is already running playmode on DX12, using Vulkan for URP will make the coverage complementary.